Skip to content

Coverage Dependence #271

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 28 commits into
base: main
Choose a base branch
from
Open

Coverage Dependence #271

wants to merge 28 commits into from

Conversation

mjohnson541
Copy link
Collaborator

Enables coverage dependence for reactions on surfaces or interfaces with surfaces.

…ge dependence

in particular this makes it so you can stick the coverage dependence on NASA and it will get passed down to
its NASAPolynomial sub objects
in particular this adjust the dispatching to help handle the fact that coverage dependence complicates automatic differentiation
When we put information in the mechanism file we don't yet know the index associated with the species coverage dependence is with respect to
this fills in the index (as opposed to species name) dictionaries on the coverage dependence objects so they are ready for efficient evaluation
also ensures gibbs free energy is output (before an empty vector was returned if it was not expected to be needed, but coverage dependence makes us needed at the interface even for domains where Gs is constant)
also fixed bug related to handling of cpdivR in output from calcthermo
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant