-
Notifications
You must be signed in to change notification settings - Fork 35
Coverage Dependence #271
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
mjohnson541
wants to merge
28
commits into
main
Choose a base branch
from
covdep
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Coverage Dependence #271
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ge dependence in particular this makes it so you can stick the coverage dependence on NASA and it will get passed down to its NASAPolynomial sub objects
in particular this adjust the dispatching to help handle the fact that coverage dependence complicates automatic differentiation
When we put information in the mechanism file we don't yet know the index associated with the species coverage dependence is with respect to this fills in the index (as opposed to species name) dictionaries on the coverage dependence objects so they are ready for efficient evaluation
…verage dependence
also ensures gibbs free energy is output (before an empty vector was returned if it was not expected to be needed, but coverage dependence makes us needed at the interface even for domains where Gs is constant)
also fixed bug related to handling of cpdivR in output from calcthermo
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Enables coverage dependence for reactions on surfaces or interfaces with surfaces.