-
Notifications
You must be signed in to change notification settings - Fork 29
Update to Python=3.9 and update Django #298
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Roel has very kindly released a binary of |
To-fix:
|
Unrelated note, but the entryEdit functionality seems kind of suspicious and maybe we shouldn't allow users to actually use those (I don't think anyone is, and they don't even work on the main site.) We may want to just remove it. |
Some Solute (tdep, soluteML) functionalities may be present in SolProp and thereby maybe we don't need chemprop_solvation. |
This PR seeks to update
RMG-website
to be compatible with Python 3.9 so that it can leverage the newest version ofRMG-Py
and other packages.To do this, a number of things need to be updated simultaneously (avoid dependency hell):
solprop
using the py3.9 compatible version, or turn it into an API service so that it can be queried separately. Updatingsolprop
would for now be the most straightforward option. Although an API service would be the best solution technologically, it would take the most technical load to learn and implement sustainably. Another way is to call it via a subprocess in its own separateconda
ordocker
environment, which would also require some rewriting of the backend. Key concern is whether it's fast enough. In the future, probably we want to move toward one of the two latter options, especially if we want to deploy more ML models on the site.There's also an opportunity to make the
conda
environment leaner (which should make solving for it more straightforward in general).