-
Notifications
You must be signed in to change notification settings - Fork 242
RMG-Py Version 3.3.0 #2826
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
RMG-Py Version 3.3.0 #2826
Conversation
An official release could be a good time to check and fix the links in the documentation?
|
Complete list of PRs at the top of this PR has been updated with categories. This will be used in the official GitHub release. Release Notes file has been updated with a high-level summary of changes and now points to the official changelog on GitHub to avoid duplication of work. @rwest agreed, good idea. @jonwzheng has graciously agreed to address these. |
Regression Testing Results
Detailed regression test results.Regression test aromatics:Reference: Execution time (DD:HH:MM:SS): 00:00:00:51 aromatics Passed Core Comparison ✅Original model has 15 species. aromatics Failed Edge Comparison ❌Original model has 106 species. Non-identical thermo! ❌
thermo: Thermo group additivity estimation: group(Cs-(Cds-Cds)(Cds-Cds)(Cds-Cds)H) + group(Cds-Cds(Cds-Cds)(Cds-Cds)) + group(Cds-CdsCsH) + group(Cds-CdsCsH) + group(Cds-Cds(Cds-Cds)H) + group(Cds-Cds(Cds-Cds)H) + group(Cds-CdsCsH) + group(Cdd-CdsCds) + Estimated bicyclic component: polycyclic(s4_6_6_ane) - ring(Cyclohexane) - ring(Cyclohexane) + ring(124cyclohexatriene) + ring(124cyclohexatriene) Non-identical kinetics! ❌
kinetics: Non-identical kinetics! ❌
kinetics: Non-identical kinetics! ❌
kinetics: Non-identical kinetics! ❌
kinetics: Non-identical kinetics! ❌
kinetics: Non-identical kinetics! ❌
kinetics: Non-identical kinetics! ❌
kinetics: Non-identical kinetics! ❌
kinetics: Non-identical kinetics! ❌
kinetics: Non-identical kinetics! ❌
kinetics: Non-identical kinetics! ❌
kinetics: Non-identical kinetics! ❌
kinetics: Non-identical kinetics! ❌
kinetics:
Observables Test Case: Aromatics Comparison
✅ All Observables varied by less than 0.500 on average between old model and new model in all conditions! aromatics Passed Observable Testing ✅Regression test liquid_oxidation:Reference: Execution time (DD:HH:MM:SS): 00:00:02:02 liquid_oxidation Passed Core Comparison ✅Original model has 37 species. liquid_oxidation Failed Edge Comparison ❌Original model has 214 species. Non-identical kinetics! ❌
kinetics:
Observables Test Case: liquid_oxidation Comparison
✅ All Observables varied by less than 0.100 on average between old model and new model in all conditions! liquid_oxidation Passed Observable Testing ✅Regression test nitrogen:Reference: Execution time (DD:HH:MM:SS): 00:00:00:59 nitrogen Passed Core Comparison ✅Original model has 41 species. nitrogen Passed Edge Comparison ✅Original model has 133 species.
Observables Test Case: NC Comparison
✅ All Observables varied by less than 0.200 on average between old model and new model in all conditions! nitrogen Passed Observable Testing ✅Regression test oxidation:Reference: Execution time (DD:HH:MM:SS): 00:00:01:35 oxidation Passed Core Comparison ✅Original model has 59 species. oxidation Passed Edge Comparison ✅Original model has 230 species.
Observables Test Case: Oxidation Comparison
✅ All Observables varied by less than 0.500 on average between old model and new model in all conditions! oxidation Passed Observable Testing ✅Errors occurred during observable testing
WARNING:root:Initial mole fractions do not sum to one; normalizing.
|
@rwest @JacksonBurns I've gone ahead and addressed any stale/broken links. I left the |
Much appreciated @jonwzheng! I looked through the changes and they all look good to me! @rwest please review! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we should rebuild the latex pdf documentation and add before tagging 3.3.0?
I just built the PDFs. They look OK - all 599 pages - at a very quick glance. Committed and pushed. |
thanks for taking care of that @rwest - I'll set this to automerge, and then we just have one last PR to merge to trigger the release! |
73eab91
into
ReactionMechanismGenerator:main
Regression Testing Results
Detailed regression test results.Regression test aromatics:Reference: Execution time (DD:HH:MM:SS): 00:00:00:51 aromatics Passed Core Comparison ✅Original model has 15 species. aromatics Failed Edge Comparison ❌Original model has 106 species. Non-identical thermo! ❌
thermo: Thermo group additivity estimation: group(Cs-(Cds-Cds)(Cds-Cds)(Cds-Cds)H) + group(Cds-Cds(Cds-Cds)(Cds-Cds)) + group(Cds-CdsCsH) + group(Cds-CdsCsH) + group(Cds-Cds(Cds-Cds)H) + group(Cds-Cds(Cds-Cds)H) + group(Cds-CdsCsH) + group(Cdd-CdsCds) + Estimated bicyclic component: polycyclic(s4_6_6_ane) - ring(Cyclohexane) - ring(Cyclohexane) + ring(124cyclohexatriene) + ring(124cyclohexatriene) Non-identical kinetics! ❌
kinetics: Non-identical kinetics! ❌
kinetics: Non-identical kinetics! ❌
kinetics: Non-identical kinetics! ❌
kinetics: Non-identical kinetics! ❌
kinetics: Non-identical kinetics! ❌
kinetics: Non-identical kinetics! ❌
kinetics: Non-identical kinetics! ❌
kinetics: Non-identical kinetics! ❌
kinetics: Non-identical kinetics! ❌
kinetics: Non-identical kinetics! ❌
kinetics: Non-identical kinetics! ❌
kinetics: Non-identical kinetics! ❌
kinetics:
Observables Test Case: Aromatics Comparison
✅ All Observables varied by less than 0.500 on average between old model and new model in all conditions! aromatics Passed Observable Testing ✅Regression test liquid_oxidation:Reference: Execution time (DD:HH:MM:SS): 00:00:02:02 liquid_oxidation Passed Core Comparison ✅Original model has 37 species. liquid_oxidation Failed Edge Comparison ❌Original model has 214 species. Non-identical kinetics! ❌
kinetics:
Observables Test Case: liquid_oxidation Comparison
✅ All Observables varied by less than 0.100 on average between old model and new model in all conditions! liquid_oxidation Passed Observable Testing ✅Regression test nitrogen:Reference: Execution time (DD:HH:MM:SS): 00:00:00:59 nitrogen Passed Core Comparison ✅Original model has 41 species. nitrogen Failed Edge Comparison ❌Original model has 133 species. Non-identical thermo! ❌
thermo: Thermo group additivity estimation: group(O2s-CdN3d) + group(N3d-OCd) + group(Cd-HN3dO) + ring(Cyclopropene) + radical(CdJ-NdO) Non-identical kinetics! ❌
kinetics:
Observables Test Case: NC Comparison
✅ All Observables varied by less than 0.200 on average between old model and new model in all conditions! nitrogen Passed Observable Testing ✅Regression test oxidation:Reference: Execution time (DD:HH:MM:SS): 00:00:01:35 oxidation Passed Core Comparison ✅Original model has 59 species. oxidation Passed Edge Comparison ✅Original model has 230 species.
Observables Test Case: Oxidation Comparison
✅ All Observables varied by less than 0.500 on average between old model and new model in all conditions! oxidation Passed Observable Testing ✅Errors occurred during observable testing
WARNING:root:Initial mole fractions do not sum to one; normalizing.
|
Thanks to the many contributors to RMG-Py over the last few years! We are now releasing RMG-Py Version 3.3.0, which contains many exciting and awesomely-awesome features. Big notes for this release - RMG-Py now uses Python 3.9 and thus runs much faster, conda binaries will be available for this release (first time in 4 years!), electrochemistry is now available in initial stages, and RMG can be run in Pure Python mode, if desired.
This PR contains last-minute changes for releasing RMG-Py Version 3.3.0, namely:
Below is the complete list of PRs, which should be categorized for the Release on GitHub and then shortened for addition to the Release Notes:
What's Changed
Software Improvements
Continuous Integration
default
Channel fromenvironment.yml
by @mjohnson541 in Removedefault
Channel fromenvironment.yml
#2712minimal_surface
Regression Test by @JacksonBurns in Patchminimal_surface
Regression Test #2674RMG-Py Itself
muq
,lpsolve55
, andRingDecomposerLib
fromrmg
toconda-forge
by @jonwzheng in Switchmuq
,lpsolve55
, andRingDecomposerLib
fromrmg
toconda-forge
#2671environment.yml
Unblocking Python 3.11 - rdkit to conda-forge channel, remove chemprop for now by @JacksonBurns inenvironment.yml
Unblocking Python 3.11 - rdkit to conda-forge channel, remove chemprop for now #2553speciesCuttingThreshold
by @donerancl in Add documentation aboutspeciesCuttingThreshold
#2601conda
Work Again 🎉 by @JacksonBurns in Make RMG-Pyconda
Work Again 🎉 #2820Bug Fixes
pytest
Discovery Bug (FooTest vs. TestFoo), Add Missing Tests, Fix Generator Tests by @rwest in Fixpytest
Discovery Bug (FooTest vs. TestFoo), Add Missing Tests, Fix Generator Tests #2525cclib
by @JacksonBurns in Fix Failing CI because ofcclib
#2535New Features (and their fixes)
Electrochemistry 🎉
Automated Fragment Modeling
regression.py
with fragment by @hwpang in Compatibility ofregression.py
with fragment #2574fragment.py
: refactoring, patches, and compatibility with RMS by @JacksonBurns infragment.py
: refactoring, patches, and compatibility with RMS #2413Surface Catalysis
AECs and BACs
Arkane
Deprecations
New Contributors
Full Changelog: 3.2.0...3.3.0