refactor: Update api endpoints #51
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NeonNature
reviewed
Sep 4, 2024
| } else { | ||
| apiThemes = Placeholders.themes; | ||
| } | ||
|
|
||
| const themes = await fetchThemesFromGitHub(apiThemes); | ||
| setThemes(themes); | ||
| if (apiThemes) { |
There was a problem hiding this comment.
I might be missing something here but wouldn't apiThemes always be present/not null because it's either the API response or the placeholders?
could also initialize with let apiThemes = Placeholder.themes instead of null if that's the case too. or is there a case the response could be null?
There was a problem hiding this comment.
You're right that the response can actually be null - if success is false then the data field will be absent 😝
There was a problem hiding this comment.
gotcha. Looks good to me, if so.
NeonNature
approved these changes
Sep 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The API response has been standardized on the backend, frontend should update to match it.
Closes #46
What change does this PR introduce?
Please select the relevant option(s).
What is the proposed approach?
Update handling of API responses based on standardized format.
Checklist: