Skip to content

Prettier Intergation #12

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 6 commits into from
Closed

Prettier Intergation #12

wants to merge 6 commits into from

Conversation

Bashamega
Copy link

Description

Please include a brief summary of the change and include the relevant issue(s).

#11 part 1

What change does this PR introduce?

Please select the relevant option(s).

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • CI/CD (updates related to the CI/CD process)
  • Documentation update (changes to docs/code comments)
  • Chore (miscellaneous tasks that do not fall into the above options)

What is the proposed approach?

Please give a short overview/explanation on the approach taken to resolve the issue(s).

Checklist:

  • The commit message follows our adopted guidelines
  • Testing has been done for the change(s) added (for bug fixes/features)
  • Relevant comments/docs have been added/updated (for bug fixes/features)

@PhuongHoang
Copy link
Contributor

I am a bit confused and wonder if this PR is the same as #11? It looks like it has the same changes as #11.

@Bashamega
Copy link
Author

I am a bit confused and wonder if this PR is the same as #11? It looks like it has the same changes as #11.

It is not the same pr.

This one is for prettier integration.

@PhuongHoang
Copy link
Contributor

I am a bit confused and wonder if this PR is the same as #11? It looks like it has the same changes as #11.

It is not the same pr.

This one is for prettier integration.

Ah I see. I think I didn't communicate very well on #11. I would love to have 2 separate PRs

  1. A PR that contains only configurations for eslint and prettier, e.g. eslint.js, .prettierrc
  2. A PR that contains the files changed because of applying eslint and prettier

It makes the first PR very small and makes it simple to review the real changes closely. The second PR can be glanced quickly since it does not contain any logical changes.

Please let me know if it can be done quickly that way. If it takes you a lot of time, I can review this PR. But for eslint, please follow the above suggestion.

@Bashamega
Copy link
Author

Sure

@Bashamega Bashamega closed this Aug 27, 2024
@PhuongHoang
Copy link
Contributor

I am very sorry, but I can't contribute to this project anymore

Oh no, I am very sorry to hear that. It is unfortunate that you are not able to contribute.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants