Display modifier key warning before unlocking, too #286
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Info about mod keys such as Caps Lock is now displayed during typing, not only on failed attempt. Original commit at i3lock: i3@deaf8b9 Signed-off-by: Alexandru Nechita <alexandru.italia32@gmail.com>
WIP Migration of the build system from autotools to meson, following the original i3lock new build system. Original commits from i3lock: https://github.com/i3/i3lock/tree/2.14 Signed-off-by: Alexandru Nechita <alexandru.italia32@gmail.com>
This reverts commit b7ac466.
Raymo111
changed the title
|
Marked this as WIP for now, unmark it and request review when you're done please 🙂 |
|
yeah for the wip i was going to make another pull request because of breaking changes and bump up in version. |
alexandru0-dev
changed the title
4 tasks
|
@Raymo111 any updates? |
|
Sorry, missed this for whatever reason. I don't see any changes/diff? |
|
@Raymo111 can you please add this feature? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Original commit at i3lock: i3@deaf8b9
No braking changes
Progression to solving #[201] as this commit DOES NOT have any braking changes
Description
Before that, you would know if u had CAPS_LOCK and/or others modifiers active only when you pressed enter to check for your password
Release notes
Notes: