fix: listen on all interfaced in Docker #299
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Having tested it, you can't override the environment variable. But are people using ipv6 as Docker's internal network protocol? That's the question. Otherwise, this PR is ok for me. |
|
Can you rebase and target the |
Nobody sane. Like, It's possible in theory, but it's a massive PITA to do and maintain. I only have v6 on my reverse proxy. |
By default, the `HOSTNAME` environment variable will have the container's hostname. NodeJS `server.listen` when used with a hostname that resolved to multiple addresses will only use the first one. By setting it to 0.0.0.0 we are restoring the default behavior of Next.js and listening on all interfaces.
|
So, I'll accept it and I will document it. Thank you :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
By default, the
HOSTNAMEenvironment variable will have the container's hostname. NodeJSserver.listenwhen used with a hostname that resolved to multiple addresses will only use the first one. By setting it to 0.0.0.0 we are restoring the default behavior of Next.js and listening on all interfaces.fixes #285
Edit: not sure if stating it like this allows the user to overwrite it