-
Notifications
You must be signed in to change notification settings - Fork 0
feat: Wazuh Cert-manager for internals certificates #57
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
clystard-csgroup
wants to merge
1
commit into
develop
Choose a base branch
from
test/wazuh-certmanager-for-internal
base: develop
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
35c8fa2
to
da51927
Compare
nleconte-csgroup
requested changes
Aug 28, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just replace the WIP namespace with the final one
c8196b6
to
1d55b02
Compare
d0b6672
to
d14a190
Compare
5d4f748
to
9d747b4
Compare
nleconte-csgroup
requested changes
Sep 5, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It looks like 3 variables are not set. See my last comments.
1ec7d3e
to
eaaf3dd
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To increase automation of installation process. Remove manual step (cf documentation Wazuh-ServerInstall "A.2 Generate self-signed certificates").
Use Cert-manager instead of self-signed internal certificates for Wazuh cluster.
More compliant with a managed Kubernetes cluster infrastructure.