[Flang] Disable Global Filtering pass by default #236
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Global Filtering Passs was created to fix linking issues for old clang driver. This pass is not upstreamed and we can switch it off for flang-new and the new clang driver. The user can still turn it by setting `-foffload-global-filtering' flag. This is the first step to completely remove global filtering pass from ATD branch and to minimize delta between ATD and upstream branches.
|
This seems fine to me as well. However, have you checked whether it will cause any lit/smoke tests that relied on it to break unless the -foffload-global-filtering flag is passed explicitly? |
|
searlmc1
added a commit
that referenced
this pull request
Feb 3, 2025
…amdeng/amd-mainline-gfx950-master [AMDGPU] Add gfx950 support.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Global Filtering Passs was created to fix linking issues
for old clang driver. This pass is not upstreamed
and we can switch it off by default for flang-new and the new clang driver.
The user can still turn on it by setting
-foffload-global-filteringflag.This is the first step to completely remove global filtering pass
from ATD branch and to minimize delta between ATD and upstream branches.