Skip to content

Fixup from upstream ORT #4189

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Aug 2, 2025
Merged

Fixup from upstream ORT #4189

merged 5 commits into from
Aug 2, 2025

Conversation

@causten
Copy link
Collaborator

@causten causten commented Jul 31, 2025 •
edited
Loading

Picked up some urgent upstream fixes to get ONNX Runtime builds working again.
Fixed Jenkins to rebuild the docker if the latest ORT commit hash has advanced as part of a PR

@causten causten self-assigned this Jul 31, 2025
@TedThemistokleous TedThemistokleous added bugfix Fixes a bug found in the code. Continous Integration Pull request updates parts of continous integration pipeline high priority A PR with high priority for review and merging. labels Aug 1, 2025
@migraphx-bot
Copy link
Collaborator

Test Batch Rate new
73262a		 Rate old
49c911		 Diff Compare
torchvision-resnet50 64 3,228.87 3,243.12 -0.44% ✅
torchvision-resnet50_fp16 64 6,930.68 6,956.65 -0.37% ✅
torchvision-densenet121 32 2,438.00 2,447.19 -0.38% ✅
torchvision-densenet121_fp16 32 4,152.92 4,170.35 -0.42% ✅
torchvision-inceptionv3 32 1,626.40 1,635.75 -0.57% ✅
torchvision-inceptionv3_fp16 32 2,741.58 2,762.57 -0.76% ✅
cadene-inceptionv4 16 766.78 771.00 -0.55% ✅
cadene-resnext64x4 16 813.60 814.42 -0.10% ✅
slim-mobilenet 64 7,422.87 7,462.18 -0.53% ✅
slim-nasnetalarge 64 210.14 211.03 -0.42% ✅
slim-resnet50v2 64 3,329.52 3,344.11 -0.44% ✅
bert-mrpc-onnx 8 1,136.64 1,147.89 -0.98% ✅
bert-mrpc-tf 1 444.53 443.33 0.27% ✅
pytorch-examples-wlang-gru 1 367.68 296.95 23.82% 🔆
pytorch-examples-wlang-lstm 1 416.98 487.56 -14.48% 🔴
torchvision-resnet50_1 1 763.51 766.84 -0.43% ✅
cadene-dpn92_1 1 391.61 384.33 1.89% ✅
cadene-resnext101_1 1 387.17 392.90 -1.46% ✅
onnx-taau-downsample 1 393.84 395.98 -0.54% ✅
dlrm-criteoterabyte 1 33.66 33.77 -0.34% ✅
dlrm-criteoterabyte_fp16 1 51.12 51.22 -0.19% ✅
agentmodel 1 9,163.55 8,748.06 4.75% 🔆
unet_fp16 2 58.95 59.17 -0.36% ✅
resnet50v1_fp16 1 990.23 959.46 3.21% 🔆
resnet50v1_int8 1 1,033.74 1,026.48 0.71% ✅
bert_base_cased_fp16 64 1,100.81 1,107.17 -0.58% ✅
bert_large_uncased_fp16 32 343.67 345.30 -0.47% ✅
bert_large_fp16 1 197.37 195.68 0.86% ✅
distilgpt2_fp16 16 2,104.73 2,118.17 -0.63% ✅
yolov5s 1 576.90 565.56 2.01% ✅
tinyllama 1 43.80 43.99 -0.41% ✅
vicuna-fastchat 1 45.05 45.20 -0.34% ✅
whisper-tiny-encoder 1 415.54 417.01 -0.35% ✅
whisper-tiny-decoder 1 399.12 409.02 -2.42% ✅
llama2_7b 1 19.12 19.15 -0.16% ✅
qwen1.5-7b 1 23.45 23.54 -0.38% ✅
phi3-3.8b 1 26.63 26.68 -0.18% ✅
mask-rcnn 1 12.45 12.28 1.40% ✅
llama3-8b 1 21.66 21.74 -0.39% ✅
whisper-large-encoder 1 10.17 10.22 -0.48% ✅
whisper-large-decoder 1 96.46 95.97 0.51% ✅
mistral-7b 1 23.65 23.72 -0.31% ✅
FLUX.1-schnell 1 744.17 740.21 0.54% ✅
nan nan nan nan nan% ❌

This build is not recommended to merge 🔴

@migraphx-bot
Copy link
Collaborator


     ✅ bert-mrpc-onnx: PASSED: MIGraphX meets tolerance

❌bert-mrpc-tf: ERROR - check error outputerror: unknown warning option '-Wnrvo' [-Werror,-Wunknown-warning-option]

error: unknown warning option '-Wnrvo' [-Werror,-Wunknown-warning-option]

2025-08-01 17:47:08.742944: I tensorflow/core/platform/cpu_feature_guard.cc:210] This TensorFlow binary is optimized to use available CPU instructions in performance-critical operations.
To enable the following instructions: SSE3 SSE4.1 SSE4.2 AVX AVX2 FMA, in other operations, rebuild TensorFlow with the appropriate compiler flags.
WARNING: All log messages before absl::InitializeLog() is called are written to STDERR
I0000 00:00:1754088434.115308 173433 gpu_device.cc:2022] Created device /job:localhost/replica:0/task:0/device:GPU:0 with 62951 MB memory: -> device: 0, name: AMD Instinct MI250X/MI250, pci bus id: 0000:32:00.0
WARNING: All log messages before absl::InitializeLog() is called are written to STDERR
I0000 00:00:1754088434.988806 173433 mlir_graph_optimization_pass.cc:401] MLIR V1 optimization pass is not enabled
2025-08-01 17:47:25.083803: E external/local_xla/xla/service/gpu/llvm_gpu_backend/gpu_backend_lib.cc:250] bitcode module is required by this HLO module but was not found at ./opencl.bc
2025-08-01 17:47:25.083850: E external/local_xla/xla/service/gpu/llvm_gpu_backend/gpu_backend_lib.cc:250] bitcode module is required by this HLO module but was not found at ./opencl.bc
2025-08-01 17:47:25.083897: E external/local_xla/xla/service/gpu/llvm_gpu_backend/gpu_backend_lib.cc:250] bitcode module is required by this HLO module but was not found at ./opencl.bc
2025-08-01 17:47:25.083951: E external/local_xla/xla/service/gpu/llvm_gpu_backend/gpu_backend_lib.cc:250] bitcode module is required by this HLO module but was not found at ./opencl.bc
2025-08-01 17:47:25.083991: E external/local_xla/xla/service/gpu/llvm_gpu_backend/gpu_backend_lib.cc:250] bitcode module is required by this HLO module but was not found at ./opencl.bc
2025-08-01 17:47:25.084025: E external/local_xla/xla/service/gpu/llvm_gpu_backend/gpu_backend_lib.cc:250] bitcode module is required by this HLO module but was not found at ./opencl.bc
2025-08-01 17:47:25.084068: E external/local_xla/xla/service/gpu/llvm_gpu_backend/gpu_backend_lib.cc:250] bitcode module is required by this HLO module but was not found at ./opencl.bc
2025-08-01 17:47:25.084232: E external/local_xla/xla/service/gpu/llvm_gpu_backend/gpu_backend_lib.cc:250] bitcode module is required by this HLO module but was not found at ./opencl.bc
error: Failure when generating HSACO
error: Failure when generating HSACO
error: Failure when generating HSACO
error: Failure when generating HSACO
error: Failure when generating HSACO
error: Failure when generating HSACO
error: Failure when generating HSACO
error: Failure when generating HSACO
2025-08-01 17:47:25.085199: E tensorflow/compiler/mlir/tools/kernel_gen/tf_framework_c_interface.cc:228] INTERNAL: Generating device code failed.
2025-08-01 17:47:25.086288: W tensorflow/core/framework/op_kernel.cc:1829] UNKNOWN: JIT compilation failed.
2025-08-01 17:47:25.086308: I tensorflow/core/framework/local_rendezvous.cc:405] Local rendezvous is aborting with status: UNKNOWN: JIT compilation failed.
[[{{node import/bert/embeddings/LayerNorm/moments/SquaredDifference}}]]
2025-08-01 17:47:25.086319: I tensorflow/core/framework/local_rendezvous.cc:405] Local rendezvous is aborting with status: UNKNOWN: JIT compilation failed.
[[{{node import/bert/embeddings/LayerNorm/moments/SquaredDifference}}]]
[[import/loss/output/_21]]
2025-08-01 17:47:25.086335: I tensorflow/core/framework/local_rendezvous.cc:424] Local rendezvous recv item cancelled. Key hash: 11217777527359497193
Traceback (most recent call last):
File "/usr/local/lib/python3.10/dist-packages/tensorflow/python/client/session.py", line 1407, in _do_call
return fn(*args)
File "/usr/local/lib/python3.10/dist-packages/tensorflow/python/client/session.py", line 1390, in _run_fn
return self._call_tf_sessionrun(options, feed_dict, fetch_list,
File "/usr/local/lib/python3.10/dist-packages/tensorflow/python/client/session.py", line 1483, in _call_tf_sessionrun
return tf_session.TF_SessionRun_wrapper(self._session, options, feed_dict,
tensorflow.python.framework.errors_impl.UnknownError: 2 root error(s) found.
(0) UNKNOWN: JIT compilation failed.
[[{{node import/bert/embeddings/LayerNorm/moments/SquaredDifference}}]]
[[import/loss/output/_21]]
(1) UNKNOWN: JIT compilation failed.
[[{{node import/bert/embeddings/LayerNorm/moments/SquaredDifference}}]]
0 successful operations.
0 derived errors ignored.

During handling of the above exception, another exception occurred:

Traceback (most recent call last):
File "/src/AMDMIGraphX/tools/accuracy/accuracy_checker.py", line 359, in
main()
File "/src/AMDMIGraphX/tools/accuracy/accuracy_checker.py", line 335, in main
y_out = sess.run(y, feed_dict=tf_dict)
File "/usr/local/lib/python3.10/dist-packages/tensorflow/python/client/session.py", line 977, in run
result = self._run(None, fetches, feed_dict, options_ptr,
File "/usr/local/lib/python3.10/dist-packages/tensorflow/python/client/session.py", line 1220, in _run
results = self._do_run(handle, final_targets, final_fetches,
File "/usr/local/lib/python3.10/dist-packages/tensorflow/python/client/session.py", line 1400, in _do_run
return self._do_call(_run_fn, feeds, fetches, targets, options,
File "/usr/local/lib/python3.10/dist-packages/tensorflow/python/client/session.py", line 1426, in _do_call
raise type(e)(node_def, op, message) # pylint: disable=no-value-for-parameter
tensorflow.python.framework.errors_impl.UnknownError: Graph execution error:

Detected at node 'import/bert/embeddings/LayerNorm/moments/SquaredDifference' defined at (most recent call last):
Node: 'import/bert/embeddings/LayerNorm/moments/SquaredDifference'
Detected at node 'import/bert/embeddings/LayerNorm/moments/SquaredDifference' defined at (most recent call last):
Node: 'import/bert/embeddings/LayerNorm/moments/SquaredDifference'
2 root error(s) found.
(0) UNKNOWN: JIT compilation failed.
[[{{node import/bert/embeddings/LayerNorm/moments/SquaredDifference}}]]
[[import/loss/output/_21]]
(1) UNKNOWN: JIT compilation failed.
[[{{node import/bert/embeddings/LayerNorm/moments/SquaredDifference}}]]
0 successful operations.
0 derived errors ignored.

Original stack trace for 'import/bert/embeddings/LayerNorm/moments/SquaredDifference':


     ✅ pytorch-examples-wlang-gru: PASSED: MIGraphX meets tolerance

     ✅ pytorch-examples-wlang-lstm: PASSED: MIGraphX meets tolerance

     ✅ dlrm-criteoterabyte: PASSED: MIGraphX meets tolerance

     ✅ agentmodel: PASSED: MIGraphX meets tolerance

🔴unet: FAILED: MIGraphX is not within tolerance - check verbose output


     ✅ resnet50v1: PASSED: MIGraphX meets tolerance

     ✅ bert_base_cased_fp16: PASSED: MIGraphX meets tolerance

🔴bert_large_uncased_fp16: FAILED: MIGraphX is not within tolerance - check verbose output


     ✅ bert_large: PASSED: MIGraphX meets tolerance

     ✅ yolov5s: PASSED: MIGraphX meets tolerance

     ✅ tinyllama: PASSED: MIGraphX meets tolerance

     ✅ vicuna-fastchat: PASSED: MIGraphX meets tolerance

     ✅ whisper-tiny-encoder: PASSED: MIGraphX meets tolerance

     ✅ whisper-tiny-decoder: PASSED: MIGraphX meets tolerance

     ✅ distilgpt2_fp16: PASSED: MIGraphX meets tolerance

     ✅ llama2_7b: PASSED: MIGraphX meets tolerance

     ✅ qwen1.5-7b: PASSED: MIGraphX meets tolerance

     ✅ phi3-3.8b: PASSED: MIGraphX meets tolerance

🔴mask-rcnn: FAILED: MIGraphX is not within tolerance - check verbose output


     ✅ llama3-8b: PASSED: MIGraphX meets tolerance

     ✅ whisper-large-decoder: PASSED: MIGraphX meets tolerance

     ✅ mistral-7b: PASSED: MIGraphX meets tolerance

     ✅ FLUX.1-schnell: PASSED: MIGraphX meets tolerance

@causten causten merged commit 8694b8d into develop Aug 2, 2025
18 of 22 checks passed
@causten causten deleted the midweek_ort_bump branch August 2, 2025 17:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@TedThemistokleous TedThemistokleous TedThemistokleous approved these changes

@ahsan-ca ahsan-ca ahsan-ca approved these changes

Assignees

@causten causten

Labels

bugfix Fixes a bug found in the code. Continous Integration Pull request updates parts of continous integration pipeline high priority A PR with high priority for review and merging.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@causten @migraphx-bot @TedThemistokleous @ahsan-ca