Skip to content

Conversation

@CharlieL7
Copy link
Collaborator

Use the parameter's name in the Netron node name so it's searchable by that.

@CharlieL7 CharlieL7 self-assigned this Jul 30, 2025
@CharlieL7 CharlieL7 requested a review from causten as a code owner July 30, 2025 19:50
@CharlieL7 CharlieL7 added the simple small or simple changes label Jul 30, 2025
Copy link
Contributor

@lakhinderwalia lakhinderwalia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved.
Subjective: @param could be appended with the ins->name(). The other way around.

@codecov
Copy link

codecov bot commented Jul 30, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #4187      +/-   ##
===========================================
+ Coverage    92.22%   92.23%   +0.01%     
===========================================
  Files          549      549              
  Lines        25343    25351       +8     
===========================================
+ Hits         23371    23380       +9     
+ Misses        1972     1971       -1     

see 5 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@migraphx-bot
Copy link
Collaborator

Test Batch Rate new
c18b80
Rate old
12da9b
Diff Compare
torchvision-resnet50 64 3,232.21 3,232.45 -0.01%
torchvision-resnet50_fp16 64 6,914.36 6,927.23 -0.19%
torchvision-densenet121 32 2,441.11 2,440.23 0.04%
torchvision-densenet121_fp16 32 4,154.77 4,149.23 0.13%
torchvision-inceptionv3 32 1,627.85 1,625.83 0.12%
torchvision-inceptionv3_fp16 32 2,746.43 2,740.17 0.23%
cadene-inceptionv4 16 767.31 766.44 0.11%
cadene-resnext64x4 16 808.82 813.21 -0.54%
slim-mobilenet 64 7,422.05 7,419.74 0.03%
slim-nasnetalarge 64 210.08 210.01 0.04%
slim-resnet50v2 64 3,330.59 3,330.33 0.01%
bert-mrpc-onnx 8 1,136.16 1,138.56 -0.21%
bert-mrpc-tf 1 443.27 441.57 0.38%
pytorch-examples-wlang-gru 1 299.04 295.53 1.19%
pytorch-examples-wlang-lstm 1 400.75 421.46 -4.92% 🔴
torchvision-resnet50_1 1 773.92 766.05 1.03%
cadene-dpn92_1 1 384.53 392.09 -1.93%
cadene-resnext101_1 1 391.58 387.17 1.14%
onnx-taau-downsample 1 393.78 393.63 0.04%
dlrm-criteoterabyte 1 33.66 33.66 0.01%
dlrm-criteoterabyte_fp16 1 51.11 51.10 0.01%
agentmodel 1 9,261.83 8,240.97 12.39% 🔆
unet_fp16 2 58.98 58.92 0.11%
resnet50v1_fp16 1 978.72 971.69 0.72%
resnet50v1_int8 1 1,036.68 1,036.17 0.05%
bert_base_cased_fp16 64 1,101.06 1,099.59 0.13%
bert_large_uncased_fp16 32 343.77 343.91 -0.04%
bert_large_fp16 1 196.78 197.04 -0.14%
distilgpt2_fp16 16 2,106.14 2,104.74 0.07%
yolov5s 1 570.91 569.52 0.25%
tinyllama 1 43.74 43.78 -0.09%
vicuna-fastchat 1 45.18 45.08 0.22%
whisper-tiny-encoder 1 415.66 414.96 0.17%
whisper-tiny-decoder 1 399.99 407.85 -1.93%
llama2_7b 1 19.10 19.12 -0.08%
qwen1.5-7b 1 23.44 23.43 0.03%
phi3-3.8b 1 26.59 26.60 -0.06%
mask-rcnn 1 12.40 12.43 -0.19%
llama3-8b 1 21.62 21.64 -0.10%
whisper-large-encoder 1 10.17 10.18 -0.09%
whisper-large-decoder 1 95.07 96.39 -1.37%
mistral-7b 1 23.64 23.66 -0.07%
FLUX.1-schnell 1 747.38 741.29 0.82%
nan nan nan nan nan%

This build is not recommended to merge 🔴

@migraphx-bot
Copy link
Collaborator


     ✅ bert-mrpc-onnx: PASSED: MIGraphX meets tolerance

❌bert-mrpc-tf: ERROR - check error outputerror: unknown warning option '-Wnrvo' [-Werror,-Wunknown-warning-option]

error: unknown warning option '-Wnrvo' [-Werror,-Wunknown-warning-option]

2025-07-30 21:14:02.200975: I tensorflow/core/platform/cpu_feature_guard.cc:210] This TensorFlow binary is optimized to use available CPU instructions in performance-critical operations.
To enable the following instructions: SSE3 SSE4.1 SSE4.2 AVX AVX2 FMA, in other operations, rebuild TensorFlow with the appropriate compiler flags.
WARNING: All log messages before absl::InitializeLog() is called are written to STDERR
I0000 00:00:1753928047.499131 170775 gpu_device.cc:2022] Created device /job:localhost/replica:0/task:0/device:GPU:0 with 62951 MB memory: -> device: 0, name: AMD Instinct MI250X/MI250, pci bus id: 0000:32:00.0
WARNING: All log messages before absl::InitializeLog() is called are written to STDERR
I0000 00:00:1753928048.361913 170775 mlir_graph_optimization_pass.cc:401] MLIR V1 optimization pass is not enabled
2025-07-30 21:14:18.534431: E external/local_xla/xla/service/gpu/llvm_gpu_backend/gpu_backend_lib.cc:250] bitcode module is required by this HLO module but was not found at ./opencl.bc
2025-07-30 21:14:18.534569: E external/local_xla/xla/service/gpu/llvm_gpu_backend/gpu_backend_lib.cc:250] bitcode module is required by this HLO module but was not found at ./opencl.bc
2025-07-30 21:14:18.534613: E external/local_xla/xla/service/gpu/llvm_gpu_backend/gpu_backend_lib.cc:250] bitcode module is required by this HLO module but was not found at ./opencl.bc
2025-07-30 21:14:18.534665: E external/local_xla/xla/service/gpu/llvm_gpu_backend/gpu_backend_lib.cc:250] bitcode module is required by this HLO module but was not found at ./opencl.bc
2025-07-30 21:14:18.534706: E external/local_xla/xla/service/gpu/llvm_gpu_backend/gpu_backend_lib.cc:250] bitcode module is required by this HLO module but was not found at ./opencl.bc
2025-07-30 21:14:18.534735: E external/local_xla/xla/service/gpu/llvm_gpu_backend/gpu_backend_lib.cc:250] bitcode module is required by this HLO module but was not found at ./opencl.bc
2025-07-30 21:14:18.534779: E external/local_xla/xla/service/gpu/llvm_gpu_backend/gpu_backend_lib.cc:250] bitcode module is required by this HLO module but was not found at ./opencl.bc
2025-07-30 21:14:18.534828: E external/local_xla/xla/service/gpu/llvm_gpu_backend/gpu_backend_lib.cc:250] bitcode module is required by this HLO module but was not found at ./opencl.bc
error: Failure when generating HSACO
error: Failure when generating HSACO
error: Failure when generating HSACO
error: Failure when generating HSACO
error: Failure when generating HSACO
error: Failure when generating HSACO
error: Failure when generating HSACO
error: Failure when generating HSACO
2025-07-30 21:14:18.535853: E tensorflow/compiler/mlir/tools/kernel_gen/tf_framework_c_interface.cc:228] INTERNAL: Generating device code failed.
2025-07-30 21:14:18.537001: W tensorflow/core/framework/op_kernel.cc:1829] UNKNOWN: JIT compilation failed.
2025-07-30 21:14:18.537021: I tensorflow/core/framework/local_rendezvous.cc:405] Local rendezvous is aborting with status: UNKNOWN: JIT compilation failed.
[[{{node import/bert/embeddings/LayerNorm/moments/SquaredDifference}}]]
2025-07-30 21:14:18.537031: I tensorflow/core/framework/local_rendezvous.cc:405] Local rendezvous is aborting with status: UNKNOWN: JIT compilation failed.
[[{{node import/bert/embeddings/LayerNorm/moments/SquaredDifference}}]]
[[import/loss/output/_21]]
2025-07-30 21:14:18.537047: I tensorflow/core/framework/local_rendezvous.cc:424] Local rendezvous recv item cancelled. Key hash: 11217777527359497193
Traceback (most recent call last):
File "/usr/local/lib/python3.10/dist-packages/tensorflow/python/client/session.py", line 1407, in _do_call
return fn(*args)
File "/usr/local/lib/python3.10/dist-packages/tensorflow/python/client/session.py", line 1390, in _run_fn
return self._call_tf_sessionrun(options, feed_dict, fetch_list,
File "/usr/local/lib/python3.10/dist-packages/tensorflow/python/client/session.py", line 1483, in _call_tf_sessionrun
return tf_session.TF_SessionRun_wrapper(self._session, options, feed_dict,
tensorflow.python.framework.errors_impl.UnknownError: 2 root error(s) found.
(0) UNKNOWN: JIT compilation failed.
[[{{node import/bert/embeddings/LayerNorm/moments/SquaredDifference}}]]
[[import/loss/output/_21]]
(1) UNKNOWN: JIT compilation failed.
[[{{node import/bert/embeddings/LayerNorm/moments/SquaredDifference}}]]
0 successful operations.
0 derived errors ignored.

During handling of the above exception, another exception occurred:

Traceback (most recent call last):
File "/src/AMDMIGraphX/tools/accuracy/accuracy_checker.py", line 359, in
main()
File "/src/AMDMIGraphX/tools/accuracy/accuracy_checker.py", line 335, in main
y_out = sess.run(y, feed_dict=tf_dict)
File "/usr/local/lib/python3.10/dist-packages/tensorflow/python/client/session.py", line 977, in run
result = self._run(None, fetches, feed_dict, options_ptr,
File "/usr/local/lib/python3.10/dist-packages/tensorflow/python/client/session.py", line 1220, in _run
results = self._do_run(handle, final_targets, final_fetches,
File "/usr/local/lib/python3.10/dist-packages/tensorflow/python/client/session.py", line 1400, in _do_run
return self._do_call(_run_fn, feeds, fetches, targets, options,
File "/usr/local/lib/python3.10/dist-packages/tensorflow/python/client/session.py", line 1426, in _do_call
raise type(e)(node_def, op, message) # pylint: disable=no-value-for-parameter
tensorflow.python.framework.errors_impl.UnknownError: Graph execution error:

Detected at node 'import/bert/embeddings/LayerNorm/moments/SquaredDifference' defined at (most recent call last):
Node: 'import/bert/embeddings/LayerNorm/moments/SquaredDifference'
Detected at node 'import/bert/embeddings/LayerNorm/moments/SquaredDifference' defined at (most recent call last):
Node: 'import/bert/embeddings/LayerNorm/moments/SquaredDifference'
2 root error(s) found.
(0) UNKNOWN: JIT compilation failed.
[[{{node import/bert/embeddings/LayerNorm/moments/SquaredDifference}}]]
[[import/loss/output/_21]]
(1) UNKNOWN: JIT compilation failed.
[[{{node import/bert/embeddings/LayerNorm/moments/SquaredDifference}}]]
0 successful operations.
0 derived errors ignored.

Original stack trace for 'import/bert/embeddings/LayerNorm/moments/SquaredDifference':


     ✅ pytorch-examples-wlang-gru: PASSED: MIGraphX meets tolerance

     ✅ pytorch-examples-wlang-lstm: PASSED: MIGraphX meets tolerance

     ✅ dlrm-criteoterabyte: PASSED: MIGraphX meets tolerance

     ✅ agentmodel: PASSED: MIGraphX meets tolerance

🔴unet: FAILED: MIGraphX is not within tolerance - check verbose output


     ✅ resnet50v1: PASSED: MIGraphX meets tolerance

     ✅ bert_base_cased_fp16: PASSED: MIGraphX meets tolerance

🔴bert_large_uncased_fp16: FAILED: MIGraphX is not within tolerance - check verbose output


     ✅ bert_large: PASSED: MIGraphX meets tolerance

     ✅ yolov5s: PASSED: MIGraphX meets tolerance

     ✅ tinyllama: PASSED: MIGraphX meets tolerance

     ✅ vicuna-fastchat: PASSED: MIGraphX meets tolerance

     ✅ whisper-tiny-encoder: PASSED: MIGraphX meets tolerance

     ✅ whisper-tiny-decoder: PASSED: MIGraphX meets tolerance

     ✅ distilgpt2_fp16: PASSED: MIGraphX meets tolerance

     ✅ llama2_7b: PASSED: MIGraphX meets tolerance

     ✅ qwen1.5-7b: PASSED: MIGraphX meets tolerance

     ✅ phi3-3.8b: PASSED: MIGraphX meets tolerance

🔴mask-rcnn: FAILED: MIGraphX is not within tolerance - check verbose output


     ✅ llama3-8b: PASSED: MIGraphX meets tolerance

     ✅ whisper-large-decoder: PASSED: MIGraphX meets tolerance

     ✅ mistral-7b: PASSED: MIGraphX meets tolerance

     ✅ FLUX.1-schnell: PASSED: MIGraphX meets tolerance

@causten causten merged commit 7b882f5 into develop Aug 2, 2025
44 of 49 checks passed
@causten causten deleted the netron_output_param_name branch August 2, 2025 17:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

simple small or simple changes

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants