Skip to content

Add in stash type attr for layernorm and additional test coverage #4147

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 15 commits into from
Jul 29, 2025
Merged

Add in stash type attr for layernorm and additional test coverage #4147

Changes from 1 commit
Commits
Show all changes
15 commits
Select commit Hold shift + click to select a range
d2e6587
Start of adding layernorm stash type
TedThemistokleous Jul 16, 2025
36fcccc
format
TedThemistokleous Jul 18, 2025
203b8ec
Update parser tests
TedThemistokleous Jul 18, 2025
143d828
Update license
TedThemistokleous Jul 18, 2025
089ab86
Don't add converts if input already is float32
TedThemistokleous Jul 18, 2025
989161e
Merge branch 'develop' into add_layernorm_stash_type
causten Jul 22, 2025
587f410
Constrain input and output types for layernorm parser
TedThemistokleous Jul 24, 2025
919cbc5
Add additional test coveraged for attr and input values
TedThemistokleous Jul 24, 2025
32bb19f
Add additional test coverage for stash type and episilon inputs
TedThemistokleous Jul 24, 2025
20b2c82
Licensing
TedThemistokleous Jul 25, 2025
7368bdb
Format
TedThemistokleous Jul 25, 2025
39bf1d2
Remove convert for mean and rsqrt outputs
TedThemistokleous Jul 25, 2025
552cf27
Cleanup attributes and input checks
TedThemistokleous Jul 25, 2025
ce524ac
Split into stages for handling inputs, attributes and stage one/two o…
TedThemistokleous Jul 25, 2025
3120c56
format
TedThemistokleous Jul 25, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 15 additions & 0 deletions src/onnx/parse_layernorm.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -71,6 +71,17 @@ struct parse_layernorm : op_parser<parse_layernorm>

auto x_shape = x->get_shape();
auto x_dtype = x_shape.type();


std::set<migraphx::shape::type_t> supported_x_types = {migraphx::shape::float_type,
migraphx::shape::bf16_type,
migraphx::shape::half_type};

if(not(contains(supported_x_types, x_dtype)))
{
MIGRAPHX_THROW("PARSE_LAYERNORM: Invalid type for input");
}

int64_t x_rank = x_shape.ndim();

if(x_rank < 2)
Expand Down Expand Up @@ -118,6 +129,10 @@ struct parse_layernorm : op_parser<parse_layernorm>
if(stash_type and x_dtype != migraphx::shape::float_type)
{
result = info.add_instruction(make_op("convert", {{"target_type", x_dtype}}), result);
}

if(stash_type and x_dtype == migraphx::shape::bf16_type)
{
mean = info.add_instruction(make_op("convert", {{"target_type", x_dtype}}), mean);
rsqrt = info.add_instruction(make_op("convert", {{"target_type", x_dtype}}), rsqrt);
}
Expand Down