Skip to content

[RCP-35] Single Feeds #105

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Draft
wants to merge 4 commits into
base: main
Choose a base branch
from
Draft

[RCP-35] Single Feeds #105

wants to merge 4 commits into from

Conversation

@EricFiZillow
Copy link

@EricFiZillow EricFiZillow commented Oct 20, 2023 •
edited by darnjo
Loading

@EnFinlay
Add RCP-035 proposal
22d09b1 
Signed-off-by: Eric Finlay <eric@rets.ly>
@EnFinlay
Switch to FeedTypes
36bd46a 
Signed-off-by: Eric Finlay <eric@rets.ly>
darnjo
darnjo reviewed Oct 25, 2023
View reviewed changes
Copy link
Member

@darnjo darnjo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Made a comment. 👍

@darnjo darnjo added this to the RCPs milestone Oct 25, 2023
@EnFinlay
Changed Fields to Field, added FeedRules
356be85 
Signed-off-by: Eric Finlay <eric@rets.ly>
@EricFiZillow
Copy link
Author

Thanks for the review Josh!

@darnjo darnjo marked this pull request as draft November 30, 2023 20:16
@darnjo
Copy link
Member

darnjo commented Nov 30, 2023

Changed to DRAFT as this PR is still in review.

Will change back once approved.

@darnjo darnjo changed the title Add RCP-035 proposal Add RCP-35 proposal Jul 1, 2024
@darnjo darnjo changed the title Add RCP-35 proposal RCP-35 - Single Feeds Jul 1, 2024
@darnjo darnjo added the DD 2.1 label Jul 1, 2024
@darnjo darnjo changed the title RCP-35 - Single Feeds RCP-35: Single Feeds Jul 1, 2024
@darnjo darnjo changed the title RCP-35: Single Feeds [RCP-35] Single Feeds Jul 3, 2024
@EnFinlay
Add actual spec table
e222c80 
Signed-off-by: Eric Finlay <eric@rets.ly>
@darnjo darnjo removed the DD 2.1 label May 15, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@darnjo darnjo darnjo left review comments

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

in progress

Projects

None yet

Milestone

RCPs

Development

Successfully merging this pull request may close these issues.

3 participants

@EricFiZillow @darnjo @EnFinlay