[minor] Fix telemetry report #31
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dentiny
commented
Oct 20, 2025
| std::string AirportExtension::Version() const | ||
| { | ||
| return "user-agent=" + airport_user_agent() + ",client=" + AIRPORT_EXTENSION_VERSION; | ||
| return StringUtil::Format("user-agent=%s,client=%s", airport_user_agent(), AIRPORT_EXTENSION_VERSION); |
There was a problem hiding this comment.
Current implementation creates multiple temporary strings, using string format yields better performance.
dentiny
force-pushed
the
hjiang/fix-telemetry-report
branch
from
c32d9ef to
9d56ff3
Compare
|
Thank you very much @dentiny! I've pushed the release into the DuckDB CI pipeline and it should be out in a few hours. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It reads to me, the telemetry reported extension name should be "airport" instead of "bitfilter".