Skip to content

Vector type added #40

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 27 commits into
base: main
Choose a base branch
from
Open

Vector type added #40

wants to merge 27 commits into from

Conversation

wendellwt
Copy link

Vector data type added

Copy link
Member

@martinRenou martinRenou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for contributing!!

It would be great to add an example of this in the examples folder

Comment on lines +59 to +63
let my_iconFeature = new Feature({
geometry: new Point(model_data['geom']),
name: 'SPI',
population: 4000,
});
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do I understand correctly it supports creating only a single feature?

I'd assume this.model.get('data') would be a feature collection.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I want to replicate the Point data type as shown in Icon Symbolizer . So I called the data parameter 'geom' which is a Point(), not a GeoJSON FeatureCollection.

That is, I want to get away from a GeoJSON FeatureCollection, otherwise a single point could have been done with a GeoJSON element (FeatureCollection) with one Feature. I think it would be difficult to update or delete one icon without changing the entire FeatureCollection.

If there is a second version, there could be multiple Points supplied in a list. But for now, I wanted to get just a single Point element published.

@wendellwt
Copy link
Author

Thanks for contributing!!

It would be great to add an example of this in the examples folder

examples/VectorLayer.ipynb has been added

wendellwt and others added 7 commits April 2, 2025 22:18
Co-authored-by: martinRenou <martin.renou@gmail.com>
Co-authored-by: martinRenou <martin.renou@gmail.com>
Co-authored-by: martinRenou <martin.renou@gmail.com>
Co-authored-by: martinRenou <martin.renou@gmail.com>
Co-authored-by: martinRenou <martin.renou@gmail.com>
Co-authored-by: martinRenou <martin.renou@gmail.com>
Co-authored-by: martinRenou <martin.renou@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants