Skip to content

Updating the about lecture #315

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Jul 30, 2024
Merged

Updating the about lecture #315

merged 4 commits into from
Jul 30, 2024

Conversation

jstac
Copy link
Contributor

@jstac jstac commented Jul 30, 2024

Misc updates to bring this lecture up to date. Currently broken because a no-execute directive isn't working as expected -- no doubt my error.

@github-actions GitHub Actions
Copy link

github-actions bot commented Jul 30, 2024 •
edited
Loading

🚀 Deployed on https://66a84a7255a8efbfe7029546--epic-agnesi-957267.netlify.app

@github-actions github-actions bot temporarily deployed to pull request July 30, 2024 01:31 Inactive
@jstac
Copy link
Contributor Author

jstac commented Jul 30, 2024

Thanks @mmcky ! Just proofreading now.

@mmcky
Copy link
Contributor

mmcky commented Jul 30, 2024

When you're ready please merge and I will tag a new release.

@jstac
Copy link
Contributor Author

jstac commented Jul 30, 2024

Hey @mmcky , pushed some minor improvements. Please review (if you have time) and then make it live.

I'll be back on email around 3pm.

@mmcky
Copy link
Contributor

mmcky commented Jul 30, 2024

thanks @jstac I will proofread now.

@github-actions github-actions bot temporarily deployed to pull request July 30, 2024 01:46 Inactive
mmcky
mmcky reviewed Jul 30, 2024
View reviewed changes
mmcky
mmcky reviewed Jul 30, 2024
View reviewed changes
lectures/about_py.md
print(f"Average: {total / count if count else 'No valid data'}")

```

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jstac I assume you want to keep this comparison to be pure python? This might be a nice addition.

And using the python library pandas

import pandas as pd

data = pd.read_csv('data.csv')
data.iloc[:, 1].mean()

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jstac I will merge this PR and make note of this suggestion. We can add it if you think it is a good idea.

mmcky
mmcky approved these changes Jul 30, 2024
View reviewed changes
Copy link
Contributor

@mmcky mmcky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

love you work @jstac -- lots of improvements here.

@github-actions github-actions bot temporarily deployed to pull request July 30, 2024 02:05 Inactive
@mmcky mmcky merged commit 59d47f9 into main Jul 30, 2024
5 checks passed
@mmcky mmcky deleted the edit_about branch July 30, 2024 02:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mmcky mmcky mmcky approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jstac @mmcky