Add a list of thread-unsafe fixtures and mark tests as thread-unsafe if usage is found #33
Conversation
| @@ -99,9 +99,16 @@ def closure(*args, **kwargs): | |||
| return inner | |||
|
|
|||
|
|
|||
| _thread_unsafe_fixtures = { | |||
| "capsys", | |||
| "recwarn", | |||
There was a problem hiding this comment.
https://github.com/pydantic/pydantic/pull/11516/files#diff-e52e4ddd58b7ef887ab03c04116e676f6280b824ab7469d5d3080e5cba4f2128R184-R191 contains a bunch more, any reason not to add those?
There was a problem hiding this comment.
And once that is done, can gh-14 be closed?
There was a problem hiding this comment.
I only included the fixture names that are available by default by pytest, otherwise it would be difficult to cover all thread-unsafe fixtures that are defined by other plugins/libraries? This goes in the same spirit as the warning handling, it only covers functions defined either in the standard library or in pytest itself
There was a problem hiding this comment.
One thing we could do is add a way to set a list of fixtures to automatically mark as unsafe in the pytest configuration.
There was a problem hiding this comment.
Thanks, makes sense. And yes, making it easy to extend the list would be nice.
See #14 (comment)