Skip to content

Add option to set number of iterations in each thread #11

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Nov 5, 2024
Merged

Add option to set number of iterations in each thread #11

merged 2 commits into from
Nov 5, 2024

Conversation

lysnikolaou
Copy link
Member

@lysnikolaou lysnikolaou commented Nov 5, 2024 •
edited by andfoy
Loading

Fixes #8

andfoy
andfoy approved these changes Nov 5, 2024
View reviewed changes
Copy link
Contributor

@andfoy andfoy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The changes look good! I don't know if it is worth to mention that pytest-xdist might cause duplicate functionality when setting iterations > 1?

@lysnikolaou
Copy link
Member Author

The changes look good! I don't know if it is worth to mention that pytest-xdist might cause duplicate functionality when setting iterations > 1?

I added a minor note. Do you think that's enough?

@andfoy
Copy link
Contributor

andfoy commented Nov 5, 2024

It is good enough, thanks @lysnikolaou

@andfoy andfoy merged commit e313fcc into Quansight-Labs:main Nov 5, 2024
8 checks passed
@lysnikolaou lysnikolaou deleted the add-iterations-option branch June 10, 2025 17:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andfoy andfoy andfoy approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add an iterations marker and CLI option
2 participants
@lysnikolaou @andfoy