Skip to content

Update romanize docs and keep space #1110

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
May 8, 2025
Merged

Update romanize docs and keep space #1110

merged 3 commits into from
May 8, 2025

Conversation

wannaphong
Copy link
Member

@wannaphong wannaphong commented May 7, 2025

Fixes #1108 #1109

Your checklist for this pull request

  • Passed code styles and structures
  • Passed code linting checks and unit test

@coveralls
Copy link

coveralls commented May 7, 2025

Coverage Status

coverage: 52.833% (+0.03%) from 52.807%
when pulling 4cb0c32 on update-docs
into aad134d on dev.

Copy link

sonarqubecloud bot commented May 8, 2025

Copy link
Member

@bact bact left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fix. LGTM

@wannaphong wannaphong merged commit 372ced4 into dev May 8, 2025
44 checks passed
wannaphong added a commit that referenced this pull request May 9, 2025
- Update romanize docs and keep space #1110
@wannaphong wannaphong mentioned this pull request May 9, 2025
@wannaphong wannaphong deleted the update-docs branch May 9, 2025 09:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

bug: the romanize function removes spaces from results
3 participants