Skip to content

Conversation

@bact
Copy link
Member

@bact bact commented Nov 10, 2024

Set RUSTFLAGS = -A unreachable_code environment for cargo test to suppressed "unreachable code" errors/warnings

  • They are warnings, still able to successfully built, in my local environment

    stable-x86_64-apple-darwin (default)
    rustc 1.82.0 (f6e511eec 2024-10-15)

  • The same warnings are converted to errors in "cargo test" in the CI and made the build/test failed (see this run for example)

I'm not sure if this flag setting is a good practice.

Will the code still not able to build elsewhere?

set RUSTFLAGS = "-A unreachable_code" when cargo test
@bact bact requested review from Gorlph and wannaphong November 10, 2024 11:01
@bact bact added the help wanted Extra attention is needed label Nov 10, 2024
@bact bact changed the title Allow unreachable code during test [nlpo3-python]: Allow unreachable code during test Nov 10, 2024
@bact bact added the infrastructure CI/CD workflow, build, publication, deploy label Nov 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

help wanted Extra attention is needed infrastructure CI/CD workflow, build, publication, deploy

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant