Init: Refactor NMM mixture, separate generators and mixtures, tests r… #6
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vkutuev
reviewed
Jul 29, 2024
src/estimators/abstract_estimator.py
Outdated
Comment on lines
21
to
33
| def get_params(self) -> dict: | ||
| return {"algorithm_name": self.algorithm_name, "params": self.params, "estimated_result": self.estimate_result} | ||
|
|
||
| def set_params(self, algorithm_name: str, params: dict | None = None) -> Self: | ||
| self.algorithm_name = algorithm_name | ||
| if params is None: | ||
| self.params = dict() | ||
| else: | ||
| self.params = params | ||
| return self | ||
|
|
||
| def get_available_algorithms(self) -> list[tuple[str, str]]: | ||
| return [key for key in self._registry.register_of_names.keys() if key[1] == self._purpose] |
There was a problem hiding this comment.
Вот тут много возьни со строками и словарями. В будущем рекомендую задуматься о рефакторинге, так как поддерживать может быть больно
| class AbstractGenerator: | ||
| @staticmethod | ||
| @abstractmethod | ||
| def canonical_generate(mixture: AbstractMixtures, size: int) -> tpg.NDArray: ... |
There was a problem hiding this comment.
Докстриги лучше здесь всё же написать
src/mixtures/nm_mixture.py
Outdated
| alpha, beta, gamma = params | ||
| return alpha, beta, gamma | ||
|
|
||
| if len(params) != 4: |
There was a problem hiding this comment.
Вот как раз такие проверки тяжело будет поддерживать. Гораздо удобнее будет создать класс под хранение параметров, который нельзя будет создать без всех необходимых параметров.
src/mixtures/nmv_mixture.py
Outdated
There was a problem hiding this comment.
У разных классов mixture больно много подозрительно похожего кода, м.б. что-то вытащить в родителя?
src/register/register.py
Outdated
| @@ -32,25 +34,36 @@ def register(self, name: str) -> Callable: | |||
| def decorator(cls: Type[T]) -> Type[T]: | |||
| if name in self.register_of_names: | |||
| raise ValueError("This name is already registered") | |||
| self.register_of_names[name] = cls | |||
| if purpose not in [ | |||
There was a problem hiding this comment.
А может для этого Enum лучше использовать?
vkutuev
approved these changes
Jul 30, 2024
Desiment
approved these changes
Jul 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…efactor