-
Notifications
You must be signed in to change notification settings - Fork 19
Correct Total System Costs Calculation #40
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Validator ReportI am the Validator. Download all artifacts here. ❗ Run failed!Download 'logs' artifact to see more details.
Model Metrics Comparing |
@lindnemi can revert including the trading costs from the total system costs. Up to you. |
cpschau
pushed a commit
to SysGF-internal/pypsa-de
that referenced
this pull request
Feb 25, 2025
Import/Export of FT is subtracted/added to the national CO2 target
lindnemi
added a commit
that referenced
this pull request
Jul 23, 2025
* include interconnector and links/line costs into total system costs * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci * take care of deprecation warnings * include energy trade costs * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci --------- Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com> Co-authored-by: Micha <michaellindner@pik-potsdam.de>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replace the function
get_economy
with a more detailed calculation of the energy system costs of one region.get_tsc(n, region
name
andcarrier
. This allows to keep lines and links that are associated with the regional energy system but are missing the name of the region in the index. Furthermore, it keeps the detail of interconnectors.filter(like=region)
statement. Therefore, ifbus0
andbus1
are associated with the region, the index is enhanced by `" {region}" to include those costs. This mostly affects TYNDP links and linesget_link_opex
/get_line_opex
Checking high resolution runs (pypsa-ariadne 20241203-force-onwind-south from 04th of December 2024)
Results with energy trade costs:
Results without energy trade costs:
Former Total System Costs
Checklist:
ariadne_all
completes without errorsexport_ariadne_variables
has been adapted to the changesnot applicable
Changelog.md
not applicable
main
has been merged into the PRYYYYMMDDdescriptive_title
not applicable