Skip to content

Conversation

lindnemi
Copy link
Collaborator

Before asking for a review for this PR make sure to complete the following checklist:

  • Workflow with target rule ariadne_all completes without errors
  • The logic of export_ariadne_variables has been adapted to the changes
  • One or several figures that validate the changes in the PR have been posted as a comment
  • A brief description of the changes has been added to Changelog.md
  • The latest main has been merged into the PR
  • The config has a new prefix of the format YYYYMMDDdescriptive_title

@lindnemi lindnemi requested a review from toniseibold January 30, 2025 12:47
Copy link
Contributor

github-actions bot commented Jan 30, 2025

Validator Report

I am the Validator. Download all artifacts here.
I'll be back and edit this comment for each new commit.

Ariadne Variables

Comparison
NRMSE Pearson
Capacity|Electricity|Gas|OC 0.577 0.447
Secondary Energy|Electricity|Hydro 0.502 -0.136
System Cost|OPEX|Methanol 0.433 -0.534
System Cost|FOM|Methanol 0.433 -0.534
System Cost|CAPEX|Methanol 0.431 -0.492
Capacity|Methanol 0.426 0.206
Price|Secondary Energy|Gases|Hydrogen 0.397 0.000
Secondary Energy Input|Electricity|Liquids 0.377 0.365
Secondary Energy|Methanol 0.377 0.365
Capacity|Electricity|Storage Converter 0.350 0.709
Capacity Additions|Methanol 0.321 0.551
Capacity Additions|Liquids|Hydrogen 0.295 0.731
Capacity Additions|Liquids 0.295 0.714
Trade|Secondary Energy|Methanol|Gross Import|Volume 0.240 0.854
Trade|Secondary Energy|Methanol|Volume 0.240 0.854
Investment|Energy Supply|Methanol 0.233 0.837
System Cost|CAPEX|Liquids|Hydrogen 0.186 0.952
System Cost|FOM|Liquids|Hydrogen 0.184 0.955
Capacity|Liquids|Hydrogen 0.174 0.958
Price|Secondary Energy|Gases|Biomass 0.156 0.000
Investment|Energy Supply|Hydrogen|Transmission and Distribution|Endogen|New-build 0.155 0.932
Secondary Energy|Liquids|Hydrogen 0.152 0.960
Investment|Energy Supply|Liquids|Hydrogen 0.151 0.940
Capacity|Liquids 0.133 0.966
Secondary Energy Input|Hydrogen|Liquids 0.131 0.972
Emissions|CO2|Model|CCU 0.127 0.953
Secondary Energy|Hydrogen|Electricity 0.115 0.981
Capacity Additions|Heat|Processes 0.114 0.954
Secondary Energy Input|Electricity|Hydrogen 0.111 0.982

NRMSE: Normalized (combined-min-max) Root Mean Square Error
Pearson: Pearson correlation coefficient
Threshold: NRMSE > 0.1
Only variables reaching the threshold are shown. Find the equivalent plot for all of them below.

Plots
Main branch Feature branch
Image not available Image not available
Image not available Image not available
Image not available Image not available
Image not available Image not available
Image not available Image not available
Image not available Image not available
Image not available Image not available
Image not available Image not available
Image not available Image not available
Image not available Image not available
Image not available Image not available
Image not available Image not available
Image not available Image not available
Image not available Image not available
Image not available Image not available
Image not available Image not available
Image not available Image not available
Image not available Image not available
Image not available Image not available
Image not available Image not available
⚠️ Note: Only the first 20 variables are shown, but more are above the threshold. Find all of them in the artifacts.

General

Plots comparison
Main branch Feature branch
Image not available Image not available
Image not available Image not available
Image not available Image not available
Image not available Image not available
Image not available Image not available
Image not available Image not available
Files comparison
Status NRMSE MAE (norm)
csvs/metrics.csv ⚠️Changed 0.000 0.07
csvs/cumulative_cost.csv ⚠️Changed 0.000 0.09
csvs/prices.csv ⚠️Changed 0.001 0.05
csvs/market_values.csv ⚠️Changed 0.007 0.06
csvs/price_statistics.csv ⚠️Changed 0.003 0.09
csvs/curtailment.csv ✅ Almost equal 0.000 0.05
csvs/energy.csv ✅ Almost equal 0.000 0.02
csvs/nodal_supply_energy.csv ✅ Almost equal 0.000 0.00
csvs/capacities.csv ✅ Almost equal 0.000 0.00
csvs/cfs.csv ✅ Almost equal 0.047 0.00
csvs/nodal_costs.csv ✅ Almost equal 0.000 0.00
csvs/nodal_capacities.csv ✅ Almost equal 0.000 0.00
csvs/nodal_cfs.csv ✅ Almost equal 0.022 0.00
csvs/supply_energy.csv ✅ Almost equal 0.000 0.04
csvs/supply.csv ✅ Almost equal 0.001 0.00
csvs/costs.csv ✅ Almost equal 0.000 0.02
csvs/weighted_prices.csv ✅ Equal

NRMSE: Normalized (combined-min-max) Root Mean Square Error
MAE (norm): Mean Absolute Error on normalized data (min-max)
Status Threshold: MAE (norm) > 0.05 and NRMSE > 0.3

Model Metrics

Benchmarks Image not available Image not available Image not available

Comparing further-refining-scenarios (1fad1bb) with main (80fc857).
Branch is 8 commits ahead and 1 commits behind.
Last updated on 2025-01-30 17:27:21 CET.

logger.info(
"Efuel export ban: Setting p_max_pu to 0 for DE renewable oil -> EU oil"
)
n.links.loc["DE renewable oil -> EU oil", "p_max_pu"] = 0
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why are you setting p_max_pu instead of removing the link?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i don't want to break anything downstream, should be improved in the long run

f"Adjusting heating stock towards hard coded values from a previous REMod run. This is only a hotfix."
) # Because REMod is not consistent and a better solution takes too long.

new_values["gas boiler"] = 11.44
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

what's that number? Mio.? Comment would be helpful

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

million

@lindnemi lindnemi merged commit 80fc857 into main Jan 30, 2025
2 of 3 checks passed
cpschau pushed a commit to SysGF-internal/pypsa-de that referenced this pull request Feb 25, 2025
Setting up main Ariadne scenarios
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants