Skip to content
This repository was archived by the owner on Mar 27, 2025. It is now read-only.

Conversation

toniseibold
Copy link
Contributor

@toniseibold toniseibold commented Jan 15, 2025

Before asking for a review for this PR make sure to complete the following checklist:

  • Workflow with target rule ariadne_all completes without errors
  • The logic of export_ariadne_variables has been adapted to the changes
    not applicable
  • One or several figures that validate the changes in the PR have been posted as a comment
  • A brief description of the changes has been added to Changelog.md
    not applicable
  • The latest main has been merged into the PR
  • The config has a new prefix of the format YYYYMMDDdescriptive_title

The report now includes a electricity balance with German title/legend/axis description, nice colors and ordered in a way that makes the plot easier to read.
caveat: the plotting does not show nice plots for a 365H run since the resampling of the data does not work properly at that temporal resolution.
Before:
elec-Jan-DE-2045
After:
elec-Jan-DE-2045

Copy link

github-actions bot commented Jan 15, 2025

Validator Report

I am the Validator. Download all artifacts here.
I'll be back and edit this comment for each new commit.

❗ Run failed!

Download 'logs' artifact to see more details.

  • main failed in: build_gas_network, base_network, build_industrial_production_per_country_tomorrow, build_industrial_production_per_country_tomorrow, build_industrial_production_per_country_tomorrow, build_industrial_production_per_country_tomorrow, build_industrial_production_per_country_tomorrow, build_industrial_production_per_country_tomorrow, build_industry_sector_ratios_intermediate, build_industry_sector_ratios_intermediate, build_industry_sector_ratios_intermediate, build_industry_sector_ratios_intermediate, build_industry_sector_ratios_intermediate, build_industry_sector_ratios_intermediate
  • plot_report_addition failed in: build_gas_network, base_network, build_industrial_production_per_country_tomorrow, build_industrial_production_per_country_tomorrow, build_industrial_production_per_country_tomorrow, build_industrial_production_per_country_tomorrow, build_industrial_production_per_country_tomorrow, build_industrial_production_per_country_tomorrow, build_industry_sector_ratios_intermediate, build_industry_sector_ratios_intermediate, build_industry_sector_ratios_intermediate, build_industry_sector_ratios_intermediate, build_industry_sector_ratios_intermediate, build_industry_sector_ratios_intermediate

Model Metrics

Benchmarks Image not available Image not available Image not available

Comparing plot_report_addition (05e5794) with main (84172e4).
Branch is 4 commits ahead and 0 commits behind.
Last updated on 2025-01-20 14:40:49 CET.

@JulianGeis JulianGeis self-requested a review January 20, 2025 14:07
@JulianGeis
Copy link
Contributor

JulianGeis commented Jan 20, 2025

What I tested:

  • code looks reasonable
  • script runs on latest results and produced reasonable results (visually)
  • df_pos and df_neg are balanced at every timestep (maximum diff for selected period is 1.3 GW (probably due to rounding)

@JulianGeis JulianGeis merged commit caca51b into main Jan 20, 2025
3 checks passed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants