Skip to content
This repository was archived by the owner on Mar 27, 2025. It is now read-only.

Conversation

JulianGeis
Copy link
Contributor

@JulianGeis JulianGeis commented Dec 11, 2024

Before asking for a review for this PR make sure to complete the following checklist:

  • Workflow with target rule ariadne_all completes without errors
  • The logic of export_ariadne_variables has been adapted to the changes
  • One or several figures that validate the changes in the PR have been posted as a comment
  • A brief description of the changes has been added to Changelog.md
  • The latest main has been merged into the PR
  • The config has a new prefix of the format YYYYMMDDdescriptive_title

Copy link

github-actions bot commented Dec 11, 2024

Validator Report

I am the Validator. Download all artifacts here.
I'll be back and edit this comment for each new commit.

❗ Run failed!

Download 'logs' artifact to see more details.

  • main failed in: build_gas_network, base_network, build_industrial_production_per_country_tomorrow, build_industrial_production_per_country_tomorrow, build_industrial_production_per_country_tomorrow, build_industrial_production_per_country_tomorrow, build_industrial_production_per_country_tomorrow, build_industrial_production_per_country_tomorrow, build_industry_sector_ratios_intermediate, build_industry_sector_ratios_intermediate, build_industry_sector_ratios_intermediate, build_industry_sector_ratios_intermediate, build_industry_sector_ratios_intermediate, build_industry_sector_ratios_intermediate
  • kernnetz-cost failed in: build_gas_network, base_network, build_industrial_production_per_country_tomorrow, build_industrial_production_per_country_tomorrow, build_industrial_production_per_country_tomorrow, build_industrial_production_per_country_tomorrow, build_industrial_production_per_country_tomorrow, build_industrial_production_per_country_tomorrow, build_industry_sector_ratios_intermediate, build_industry_sector_ratios_intermediate, build_industry_sector_ratios_intermediate, build_industry_sector_ratios_intermediate, build_industry_sector_ratios_intermediate, build_industry_sector_ratios_intermediate

Model Metrics

Benchmarks Image not available Image not available Image not available

Comparing kernnetz-cost (4d07f1a) with main (fd114b0).
Branch is 11 commits ahead and 0 commits behind.
Last updated on 2025-01-24 12:50:43 CET.

@JulianGeis
Copy link
Contributor Author

  • fix: pipes from Kernnetz data in the model are over-proportinally many retrofitted projects as they are longer
  • do not use own cost data for retrofitted and new build pipes as this would underestimate the investment cost
  • reconstruct average Kernnetz invest (250€/MW*km) from our costs data

Before:

  • we only captured 9 Mrd € for roughly 80 % of the Kernnetz investment (0.8*15 = 12 Mrd €)
    Kernnetz_Investment_plot

After:
now we cover 12 Mrd €
Kernnetz_Investment_plot

the difference in the plots is because of the difference currency years (2020 vs. 2023)

@JulianGeis JulianGeis marked this pull request as ready for review December 11, 2024 13:19
@JulianGeis
Copy link
Contributor Author

I also fixed this bug on top of this PR: https://discord.com/channels/914472852571426846/1148559814381805588/1315709043989282937 (changes only in plot_ariadne_report)

- vopt
clusters:
- 27 #current options: 27, 49
- 49 #current options: 27, 49
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please revert the config changes

lindnemi added a commit that referenced this pull request Dec 12, 2024
lindnemi added a commit that referenced this pull request Dec 17, 2024
* adding FOM rows to dataframe

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

* add OPEX computation

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

* add grid variables

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

* differentiationg temporal scope of investment, annuities and FOM

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

* fix importing of the costs.csv

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

* correct FOM for special case of offwind generators

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

* integrating Kernnetz changes from PR #305

---------

Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
@JulianGeis JulianGeis marked this pull request as draft January 23, 2025 19:35
@JulianGeis JulianGeis marked this pull request as ready for review January 24, 2025 08:44

m = network.copy()
m.remove("Bus", m.buses[m.buses.x == 0].index)
m.remove("Bus", m.buses[m.buses.x == 0].index)
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

does this really need to be called twice?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

probably a merging duplicate

@lindnemi lindnemi merged commit 1334fd1 into main Jan 25, 2025
3 checks passed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants