Skip to content
This repository was archived by the owner on Mar 27, 2025. It is now read-only.

Conversation

JulianGeis
Copy link
Contributor

@JulianGeis JulianGeis commented Dec 4, 2024

Before asking for a review for this PR make sure to complete the following checklist:

  • Workflow with target rule ariadne_all completes without errors
  • The logic of export_ariadne_variables has been adapted to the changes
  • One or several figures that validate the changes in the PR have been posted as a comment
  • A brief description of the changes has been added to Changelog.md
  • The latest main has been merged into the PR
  • The config has a new prefix of the format YYYYMMDDdescriptive_title

@JulianGeis JulianGeis marked this pull request as ready for review December 4, 2024 13:20
@JulianGeis JulianGeis requested a review from lindnemi December 4, 2024 13:20
@JulianGeis
Copy link
Contributor Author

2025

no delay:

INFO:main:Dropping transmission projects with build year <= 2024. They are likely already in the OSM base network.
INFO:main:Forcing in NEP offshore DC projects with capacity:
name
DE0 4 2700
Name: Übertragungsleistung in MW, dtype: int64
INFO:main:Forcing in NEP offshore AC projects with capacity:
name
DE0 0 750
Name: Übertragungsleistung in MW, dtype: int64

delay:

INFO:main:Dropping transmission projects with build year <= 2024. They are likely already in the OSM base network.
INFO:main:Delaying NEP offshore connection points by 1 years.
INFO:main:Forcing in NEP offshore DC projects with capacity:
name
DE0 4 2700
Name: Übertragungsleistung in MW, dtype: int64
INFO:main:Forcing in NEP offshore AC projects with capacity:
name
DE0 0 750
Name: Übertragungsleistung in MW, dtype: int64

2030

no delay:

INFO:main:Dropping transmission projects with build year <= 2024. They are likely already in the OSM base network.
INFO:main:Forcing in NEP offshore DC projects with capacity:
name
DE0 0 2000
DE0 4 9800
DE0 7 4980
Name: Übertragungsleistung in MW, dtype: int64
INFO:main:Forcing in NEP offshore AC projects with capacity:
name
DE0 0 300
Name: Übertragungsleistung in MW, dtype: int64

delay:

INFO:main:Dropping transmission projects with build year <= 2024. They are likely already in the OSM base network.
INFO:main:Delaying NEP offshore connection points by 1 years.
INFO:main:Forcing in NEP offshore DC projects with capacity:
name
DE0 4 3800
DE0 7 980
Name: Übertragungsleistung in MW, dtype: int64
INFO:main:Forcing in NEP offshore AC projects with capacity:
name
DE0 0 300
Name: Übertragungsleistung in MW, dtype: int64

2035

  • no more projects bc of cutout year

no delay:

delay:

INFO:main:Delaying NEP offshore connection points by 1 years.

Copy link

github-actions bot commented Dec 4, 2024

Validator Report

I am the Validator. Download all artifacts here.
I'll be back and edit this comment for each new commit.

⚠️ Config changes detected!

Results may differ due to these changes:

diff --git a/config/config.yaml b/config/config.yaml
index ba21fb2..0a8fe37 100644
--- a/config/config.yaml
+++ b/config/config.yaml
@@ -683,6 +683,7 @@ onshore_nep_force:
 offshore_nep_force:
   cutin_year: 2025
   cutout_year: 2030
+  delay_years: 0
 
 scale_capacity:
   2020:

Ariadne Variables

Comparison
NRMSE Pearson
Capacity|Hydrogen|Gas|w/ CCS 0.634 0.131
System Cost|Capex|Hydrogen|Gas|w/ CCS 0.634 0.130
Investment|Energy Supply|Liquids|Biomass 0.577 0.000
Capacity|Electricity|Storage Converter 0.447 0.143
System Cost|OPEX|Electricity|Storage Converter|Stationary Batteries 0.431 0.193
System Cost|OPEX|Electricity|Hydrogen|OC 0.424 0.227
System Cost|OPEX|Electricity|Hydro 0.422 0.488
System Cost|OPEX|Electricity|Storage Reservoir|Hydro Dam Reservoir 0.415 0.131
System Cost|OPEX|Electricity|Storage Converter|Hydro Dam Reservoir 0.415 0.131
Capacity Additions|Liquids|Biomass 0.408 -0.200
Capacity|Liquids|Biomass 0.408 -0.200
System Cost|OPEX|Liquids|Biomass 0.408 -0.428
System Cost|Capex|Liquids|Biomass 0.408 -0.442
System Cost|Capex|Electricity|Hydrogen|OC 0.400 0.314
Investment|Energy Supply|Hydrogen|Gas|w/ CCS 0.346 0.907
System Cost|Capex|Gases|Hydrogen 0.342 0.548
System Cost|Capex|Electricity|Storage Reservoir|Stationary Batteries 0.337 0.537
System Cost|Capex|Electricity|Storage Reservoir 0.337 0.537
System Cost|Capex|Heat|Biomass|w/ CCS 0.323 0.532
System Cost|OPEX|Hydrogen|Gas|w/ CCS 0.319 0.820
System Cost|OPEX|Heat|Biomass|w/ CCS 0.318 0.535
Secondary Energy|Electricity|Hydro 0.316 0.731
System Cost|Capex|Electricity|Hydrogen|FC 0.307 0.642
Capacity Additions|Hydrogen|Gas|w/ CCS 0.305 0.878
System Cost|Capex|Electricity|Gas|w/ CCS 0.292 0.694
Capacity|Electricity|Gas|OC 0.289 0.655
Price|Secondary Energy|Gases|Hydrogen 0.286 0.000
System Cost|OPEX|Electricity|Gas|w/ CCS 0.273 0.822
System Cost|Capex|Electricity|Gas|OC 0.265 0.800
System Cost|OPEX|Electricity|Storage Converter 0.186 0.892
System Cost|OPEX|Electricity|Storage Reservoir 0.186 0.892
Emissions|CO2|Efuels|Gases 0.140 0.953
Final Energy|Industry excl Non-Energy Use|Gases|Biomass 0.131 0.957
Final Energy|Industry|Gases|Biomass 0.131 0.957
Final Energy|Non-Energy Use|Gases|Biomass 0.131 0.960
Final Energy|Gases|Biomass 0.128 0.964
Trade|Secondary Energy|Gases|Biomass|Gross Import|Volume 0.120 1.000
Investment|Energy Supply|Liquids 0.107 0.984
Investment|Energy Supply|Hydrogen|Transmission and Distribution|Endogen|New-build 0.106 0.976

NRMSE: Normalized (combined-min-max) Root Mean Square Error
Pearson: Pearson correlation coefficient
Threshold: NRMSE > 0.1
Only variables reaching the threshold are shown. Find the equivalent plot for all of them below.

Plots
Main branch Feature branch
Image not available Image not available
Image not available Image not available
Image not available Image not available
Image not available Image not available
Image not available Image not available
Image not available Image not available
Image not available Image not available
Image not available Image not available
Image not available Image not available
Image not available Image not available
Image not available Image not available
Image not available Image not available
Image not available Image not available
Image not available Image not available
Image not available Image not available
Image not available Image not available
Image not available Image not available
Image not available Image not available
Image not available Image not available
Image not available Image not available
⚠️ Note: Only the first 20 variables are shown, but more are above the threshold. Find all of them in the artifacts.

General

Plots comparison
Main branch Feature branch
Image not available Image not available
Image not available Image not available
Image not available Image not available
Image not available Image not available
Image not available Image not available
Image not available Image not available
Files comparison
Status NRMSE MAE (norm)
csvs/prices.csv ⚠️Changed 0.001 0.05
csvs/curtailment.csv ⚠️Changed 0.000 0.13
csvs/price_statistics.csv ⚠️Changed 0.002 0.12
csvs/cumulative_cost.csv ⚠️Changed 0.000 0.12
csvs/metrics.csv ⚠️Changed 0.000 0.08
csvs/nodal_cfs.csv ⚠️ NaN mismatch
csvs/supply.csv ✅ Almost equal 0.001 0.00
csvs/nodal_supply_energy.csv ✅ Almost equal 0.000 0.00
csvs/capacities.csv ✅ Almost equal 0.000 0.00
csvs/nodal_costs.csv ✅ Almost equal 0.000 0.00
csvs/market_values.csv ✅ Almost equal 0.006 0.04
csvs/nodal_capacities.csv ✅ Almost equal 0.000 0.00
csvs/cfs.csv ✅ Almost equal 0.021 0.00
csvs/costs.csv ✅ Almost equal 0.000 0.02
csvs/supply_energy.csv ✅ Almost equal 0.000 0.01
csvs/energy.csv ✅ Almost equal 0.000 0.03
csvs/weighted_prices.csv ✅ Equal

NRMSE: Normalized (combined-min-max) Root Mean Square Error
MAE (norm): Mean Absolute Error on normalized data (min-max)
Status Threshold: MAE (norm) > 0.05 and NRMSE > 0.3

Model Metrics

Benchmarks Image not available Image not available Image not available

Comparing delay-offshore-NEP (4d584e8) with main (32dadd8).
Branch is 9 commits ahead and 0 commits behind.
Last updated on 2024-12-05 12:57:59 CET.

@lindnemi lindnemi merged commit 1cff209 into main Dec 5, 2024
3 checks passed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants