Skip to content

fix(admin): Admin endpoint are no longer cached #358

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 25, 2025
Merged

fix(admin): Admin endpoint are no longer cached #358

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion PxWeb/Program.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,7 +32,7 @@

namespace PxWeb
{
public class Program

Check warning on line 35 in PxWeb/Program.cs

View workflow job for this annotation

GitHub Actions / build 

Add a 'protected' constructor or the 'static' keyword to the class declaration. (https://rules.sonarsource.com/csharp/RSPEC-1118)

Check warning on line 35 in PxWeb/Program.cs

View workflow job for this annotation

GitHub Actions / build 

Add a 'protected' constructor or the 'static' keyword to the class declaration. (https://rules.sonarsource.com/csharp/RSPEC-1118)

Check warning on line 35 in PxWeb/Program.cs

View workflow job for this annotation

GitHub Actions / build 

Add a 'protected' constructor or the 'static' keyword to the class declaration. (https://rules.sonarsource.com/csharp/RSPEC-1118)
{
public static void Main(string[] args)
{
Expand Down Expand Up @@ -110,7 +110,7 @@
)
.AddNewtonsoftJson(opts =>
{
//opts.SerializerSettings.ContractResolver = new CamelCasePropertyNamesContractResolver();

Check warning on line 113 in PxWeb/Program.cs

View workflow job for this annotation

GitHub Actions / build 

Remove this commented out code. (https://rules.sonarsource.com/csharp/RSPEC-125)

Check warning on line 113 in PxWeb/Program.cs

View workflow job for this annotation

GitHub Actions / build 

Remove this commented out code. (https://rules.sonarsource.com/csharp/RSPEC-125)

Check warning on line 113 in PxWeb/Program.cs

View workflow job for this annotation

GitHub Actions / build 

Remove this commented out code. (https://rules.sonarsource.com/csharp/RSPEC-125)
opts.SerializerSettings.ContractResolver = new BaseFirstContractResolver();
opts.SerializerSettings.Converters.Add(new StringEnumConverter
{
Expand Down Expand Up @@ -184,7 +184,7 @@
{
app.UseAuthorization();

app.UseWhen(context => context.Request.Path.StartsWithSegments(pxApiConfiguration.RoutePrefix + "/admin") || context.Request.Path.StartsWithSegments("/admin"), appBuilder =>

Check warning on line 187 in PxWeb/Program.cs

View workflow job for this annotation

GitHub Actions / build 

Define a constant instead of using this literal '/admin' 5 times. (https://rules.sonarsource.com/csharp/RSPEC-1192)

Check warning on line 187 in PxWeb/Program.cs

View workflow job for this annotation

GitHub Actions / build 

Define a constant instead of using this literal '/admin' 5 times. (https://rules.sonarsource.com/csharp/RSPEC-1192)

Check warning on line 187 in PxWeb/Program.cs

View workflow job for this annotation

GitHub Actions / build 

Define a constant instead of using this literal '/admin' 5 times. (https://rules.sonarsource.com/csharp/RSPEC-1192)
{
appBuilder.UseAdminProtectionIpWhitelist();
appBuilder.UseAdminProtectionKey();
Expand All @@ -197,7 +197,7 @@
app.UseIpRateLimiting();
}

app.UseWhen(context => !context.Request.Path.StartsWithSegments(pxApiConfiguration.RoutePrefix + "/admin") || context.Request.Path.StartsWithSegments("/admin"), appBuilder =>
app.UseWhen(context => !(context.Request.Path.StartsWithSegments(pxApiConfiguration.RoutePrefix + "/admin") || context.Request.Path.StartsWithSegments("/admin")), appBuilder =>
{
appBuilder.UseCacheMiddleware();
});
Expand Down