Skip to content

Fixed name of grouping and valuesets #217

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 29, 2024
Merged

Fixed name of grouping and valuesets #217

merged 1 commit into from
Oct 29, 2024

Conversation

likp
Copy link
Contributor

@likp likp commented Oct 28, 2024 •
edited
Loading

Added agg_ and vs_ prefixes to the classification identifyer in the result for the default selection too match the metadata.

@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

JohannesFinsveen
JohannesFinsveen approved these changes Oct 29, 2024
View reviewed changes
Copy link
Contributor

@JohannesFinsveen JohannesFinsveen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@likp likp merged commit 0b7a2a5 into main Oct 29, 2024
8 checks passed
@likp likp deleted the fix/default-selection-classification-name branch October 29, 2024 09:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JohannesFinsveen JohannesFinsveen JohannesFinsveen approved these changes

@runejo runejo Awaiting requested review from runejo runejo is a code owner

@SjurSutterudSagen SjurSutterudSagen Awaiting requested review from SjurSutterudSagen

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@likp @JohannesFinsveen