Misc fixes in the pivot functionallity

PxWeb.UnitTests/Data/VariablePlacementTests.cs

@@ -0,0 +1,319 @@
+namespace PxWeb.UnitTests.Data
+{
+
+    [TestClass]
+    public class VariablePlacementTests
+    {
+        [TestMethod]
+        public void ShouldReturnNoPreferredPlacementIfPlacemntIsNull()
+        {
+            // Arrange
+            IPlacementHandler placementHandler = new PlacementHandler();
+            VariablesSelection variablesSelection = new VariablesSelection();
+            variablesSelection.Palcement = null;
+            Selection[]? selection = GetSelectionForAllVariables();
+            PXMeta meta = ModelStore.CreateModelA().Meta;
+            Problem? problem;
+
+            // Act
+            var placement = placementHandler.GetPlacment(variablesSelection,
+                                                         selection,
+                                                         meta,
+                                                         out problem);
+
+            // Assert
+            Assert.IsNull(problem);
+            Assert.IsNull(placement);
+
+        }
+
+        [TestMethod]
+        public void ShouldReturnNoPreferredPlacementIfPlacemntIsNull2()
+        {
+            // Arrange
+            IPlacementHandler placementHandler = new PlacementHandler();
+            VariablesSelection variablesSelection = new VariablesSelection();
+            variablesSelection.Palcement = new VariablePlacementType();
+            Selection[]? selection = GetSelectionForAllVariables();
+            PXMeta meta = ModelStore.CreateModelA().Meta;
+            Problem? problem;
+
+            // Act
+            var placement = placementHandler.GetPlacment(variablesSelection,
+                                                         selection,
+                                                         meta,
+                                                         out problem);
+
+            // Assert
+            Assert.IsNull(problem);
+            Assert.IsNull(placement);
+
+        }
+
+        [TestMethod]
+        public void ShouldReturnNoPreferredPlacementIfPlacemntIsEmpty()
+        {
+            // Arrange
+            IPlacementHandler placementHandler = new PlacementHandler();
+            VariablesSelection variablesSelection = new VariablesSelection();
+
+            variablesSelection.Palcement = new VariablePlacementType();
+            variablesSelection.Palcement.Heading = new List<string>();
+            variablesSelection.Palcement.Stub = new List<string>();
+            Selection[]? selection = GetSelectionForAllVariables();
+            PXMeta meta = ModelStore.CreateModelA().Meta;
+
+            Problem? problem;
+
+            // Act
+            var placement = placementHandler.GetPlacment(variablesSelection,
+                                                         selection,
+                                                         meta,
+                                                         out problem);
+
+            // Assert
+            Assert.IsNull(problem);
+            Assert.IsNull(placement);
+
+        }
+
+        [TestMethod]
+        public void ShouldReturnNoPreferredPlacementIfPlacemntVariableDoesNotExist()
+        {
+            // Arrange
+            IPlacementHandler placementHandler = new PlacementHandler();
+            VariablesSelection variablesSelection = new VariablesSelection();
+
+            variablesSelection.Palcement = new VariablePlacementType();
+            variablesSelection.Palcement.Heading = new List<string>();
+            variablesSelection.Palcement.Heading.Add("Age");
+            variablesSelection.Palcement.Stub = new List<string>();
+            Selection[]? selection = GetSelectionForAllVariables();
+            PXMeta meta = ModelStore.CreateModelA().Meta;
+
+            Problem? problem;
+
+            // Act
+            var placement = placementHandler.GetPlacment(variablesSelection,
+                                                         selection,
+                                                         meta,
+                                                         out problem);
+
+            // Assert
+            Assert.IsNotNull(problem);
+            Assert.IsNull(placement);
+        }
+
+        [TestMethod]
+        public void ShouldReturnNoPreferredPlacementIfPlacemntVariableIsDouplicated()
+        {
+            // Arrange
+            IPlacementHandler placementHandler = new PlacementHandler();
+            VariablesSelection variablesSelection = new VariablesSelection();
+
+            variablesSelection.Palcement = new VariablePlacementType();
+            variablesSelection.Palcement.Heading = new List<string>();
+            variablesSelection.Palcement.Heading.Add("PointOfTime");
+            variablesSelection.Palcement.Heading.Add("MEASURE");
+            variablesSelection.Palcement.Stub = new List<string>();
+            variablesSelection.Palcement.Stub.Add("PointOfTime");
+            Selection[]? selection = GetSelectionForAllVariables();
+            PXMeta meta = ModelStore.CreateModelA().Meta;
+
+            Problem? problem;
+
+            // Act
+            var placement = placementHandler.GetPlacment(variablesSelection,
+                                                         selection,
+                                                         meta,
+                                                         out problem);
+
+            // Assert
+            Assert.IsNotNull(problem);
+            Assert.IsNull(placement);
+        }
+
+        [TestMethod]
+        public void ShouldNotReturnPreferredPlacementWhenUsingTime()
+        {
+            // Arrange
+            IPlacementHandler placementHandler = new PlacementHandler();
+            VariablesSelection variablesSelection = new VariablesSelection();
+
+            variablesSelection.Palcement = new VariablePlacementType();
+            variablesSelection.Palcement.Heading = new List<string>();
+            variablesSelection.Palcement.Heading.Add("TIME");
+            variablesSelection.Palcement.Heading.Add("MEASURE");
+            variablesSelection.Palcement.Stub = new List<string>();
+            variablesSelection.Palcement.Stub.Add("PointOfTime");
+            Selection[]? selection = GetSelectionForAllVariables();
+            PXMeta meta = ModelStore.CreateModelA().Meta;
+
+            Problem? problem;
+
+            // Act
+            var placement = placementHandler.GetPlacment(variablesSelection,
+                                                         selection,
+                                                         meta,
+                                                         out problem);
+
+            // Assert
+            Assert.IsNotNull(problem);
+            Assert.IsNull(placement);
+        }
+
+        [TestMethod]
+        public void ShouldNotReturnPreferredPlacementWhenSpecifyingTooManyVariables()
+        {
+            // Arrange
+            IPlacementHandler placementHandler = new PlacementHandler();
+            VariablesSelection variablesSelection = new VariablesSelection();
+
+            variablesSelection.Palcement = new VariablePlacementType();
+            variablesSelection.Palcement.Heading = new List<string>();
+            variablesSelection.Palcement.Heading.Add("TIME");
+            variablesSelection.Palcement.Heading.Add("MEASURE");
+            variablesSelection.Palcement.Stub = new List<string>();
+            variablesSelection.Palcement.Stub.Add("Measure");
+            variablesSelection.Palcement.Stub.Add("X");
+            Selection[]? selection = GetSelectionForAllVariables();
+            PXMeta meta = ModelStore.CreateModelA().Meta;
+
+            Problem? problem;
+
+            // Act
+            var placement = placementHandler.GetPlacment(variablesSelection,
+                                                         selection,
+                                                         meta,
+                                                         out problem);
+
+            // Assert
+            Assert.IsNotNull(problem);
+            Assert.IsNull(placement);
+        }
+
+
+        [TestMethod]
+        public void ShouldReturnPreferredPlacementWhenUsingTime()
+        {
+            // Arrange
+            IPlacementHandler placementHandler = new PlacementHandler();
+            VariablesSelection variablesSelection = new VariablesSelection();
+
+            variablesSelection.Palcement = new VariablePlacementType();
+            variablesSelection.Palcement.Heading = new List<string>();
+            variablesSelection.Palcement.Heading.Add("TIME");
+            variablesSelection.Palcement.Heading.Add("MEASURE");
+            variablesSelection.Palcement.Stub = new List<string>();
+            variablesSelection.Palcement.Stub.Add("GENDER");
+            Selection[]? selection = GetSelectionForAllVariables();
+            PXMeta meta = ModelStore.CreateModelA().Meta;
+
+            Problem? problem;
+
+            // Act
+            var placement = placementHandler.GetPlacment(variablesSelection,
+                                                         selection,
+                                                         meta,
+                                                         out problem);
+
+            // Assert
+            Assert.IsNull(problem);
+            Assert.IsNotNull(placement);
+            Assert.AreEqual(2, placement.Heading.Count);
+        }
+
+        [TestMethod]
+        public void ShouldReturnPreferredPlacementWhenOnlySpecifyingHeading()
+        {
+            // Arrange
+            IPlacementHandler placementHandler = new PlacementHandler();
+            VariablesSelection variablesSelection = new VariablesSelection();
+
+            variablesSelection.Palcement = new VariablePlacementType();
+            variablesSelection.Palcement.Heading = new List<string>();
+            variablesSelection.Palcement.Heading.Add("MEASURE");
+            variablesSelection.Palcement.Stub = new List<string>();
+            Selection[]? selection = GetSelectionForAllVariables();
+            PXMeta meta = ModelStore.CreateModelA().Meta;
+
+            Problem? problem;
+
+            // Act
+            var placement = placementHandler.GetPlacment(variablesSelection,
+                                                         selection,
+                                                         meta,
+                                                         out problem);
+
+            // Assert
+            Assert.IsNull(problem);
+            Assert.IsNotNull(placement);
+            Assert.AreEqual(2, placement.Stub.Count);
+        }
+
+        [TestMethod]
+        public void ShouldReturnPreferredPlacementWhenOnlySpecifyingHeadingWithElimination()
+        {
+            // Arrange
+            IPlacementHandler placementHandler = new PlacementHandler();
+            VariablesSelection variablesSelection = new VariablesSelection();
+
+            variablesSelection.Palcement = new VariablePlacementType();
+            variablesSelection.Palcement.Heading = new List<string>();
+            variablesSelection.Palcement.Heading.Add("MEASURE");
+            variablesSelection.Palcement.Stub = new List<string>();
+            Selection[]? selection = GetSelectionForMandantoryVariables();
+            PXMeta meta = ModelStore.CreateModelA().Meta;
+
+            Problem? problem;
+
+            // Act
+            var placement = placementHandler.GetPlacment(variablesSelection,
+                                                         selection,
+                                                         meta,
+                                                         out problem);
+
+            // Assert
+            Assert.IsNull(problem);
+            Assert.IsNotNull(placement);
+            Assert.AreEqual(1, placement.Stub.Count);
+        }
+
+        private static Selection[] GetSelectionForAllVariables()
+        {
+            var selections = new List<Selection>();
+            var selection = new Selection("PointOfTime");
+            selection.ValueCodes.Add("2000");
+            selection.ValueCodes.Add("2001");
+            selection.ValueCodes.Add("2002");
+            selections.Add(selection);
+            selection = new Selection("Measure");
+            selection.ValueCodes.Add("M1");
+            selections.Add(selection);
+            selection = new Selection("GENDER");
+            selection.ValueCodes.Add("M");
+            selections.Add(selection);
+            return selections.ToArray();
+
+        }
+
+
+        private static Selection[] GetSelectionForMandantoryVariables()
+        {
+            var selections = new List<Selection>();
+            var selection = new Selection("PointOfTime");
+            selection.ValueCodes.Add("2000");
+            selection.ValueCodes.Add("2001");
+            selection.ValueCodes.Add("2002");
+            selections.Add(selection);
+            selection = new Selection("Measure");
+            selection.ValueCodes.Add("M1");
+            selections.Add(selection);
+            selection = new Selection("GENDER");
+            selections.Add(selection);
+            return selections.ToArray();
+        }
+
+
+    }
+}

PxWeb.UnitTests/ModelStore.cs

@@ -2,6 +2,49 @@
 {
     internal static class ModelStore
     {
+
+        public static PXModel CreateModelA()
+        {
+
+            PXModel model = new PXModel();
+            PXMeta meta = new PXMeta();
+
+            // Create time variable
+            var name = "PointOfTime";
+            Variable variable = new Variable(name, PlacementType.Heading);
+
+            for (int i = 1968; i < 2025; i++)
+            {
+                variable.Values.Add(CreateValue($"{i}"));
+            }
+            variable.TimeValue = $"TLIST(A, \"1968\"-\"2025\")";
+            variable.IsTime = true;
+            meta.AddVariable(variable);
+
+            // Create content variable
+            name = $"MEASURE";
+            variable = new Variable(name, PlacementType.Heading);
+            variable.Values.Add(CreateValue($"M1"));
+            variable.Values.Add(CreateValue($"M2"));
+            variable.Elimination = false;
+            variable.IsContentVariable = true;
+            meta.Variables.Add(variable);
+
+            //Create classification variable gender
+
+            name = "GENDER";
+
+            variable = new Variable(name, PlacementType.Stub);
+            variable.Values.Add(CreateValue($"M"));
+            variable.Values.Add(CreateValue($"F"));
+            variable.Elimination = true;
+            meta.Variables.Add(variable);
+
+            model.Meta = meta;
+            return model;
+        }
+
+
         public static PXModel GetModelWithOnlyOneVariable(int numberOfValues)
         {
 

PxWeb/Code/Api2/DataSelection/IPlacementHandler.cs

@@ -0,0 +1,11 @@
+using PCAxis.Paxiom;
+
+using PxWeb.Api2.Server.Models;
+
+namespace PxWeb.Code.Api2.DataSelection
+{
+    public interface IPlacementHandler
+    {
+        VariablePlacementType? GetPlacment(VariablesSelection variablesSelection, Selection[] selection, PXMeta meta, out Problem? problem);
+    }
+}