New algoritm for default selection #189
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ass for readability
The initialization of the `selections` list is now conditional based on the presence of `contents` and `time` variables. Replaced commented-out code with active code to verify valid selections and check the number of cells selected, returning appropriate problems if checks fail. Set `problem` to `null` if all checks pass and return the `selections` array. Removed `throw new NotImplementedException();` indicating the method is now fully implemented. Streamlined the loop processing non-mandatory classification variables by removing the commented-out `foreach` loop.
… that the rest are in the heading
likp
requested review from
MikaelNordberg and
runejo
and removed request for
MikaelNordberg
MikaelNordberg
approved these changes
Sep 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR contains changes to the default selection algoritm according to the new version of it.
It ALso contains some refactoring of the Problem class that has men moved to a utility class thereby removing some code duplications.