initial, metadata endpoint for json-stat2 #123
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
runejo
requested changes
May 28, 2024
There was a problem hiding this comment.
Looks good 👍 but can you also include then links to both metadata formats in navigation, something like this PxTools/PxApiSpecs@master...table-metadata-formats
Ok, we'll do this as a seperate PR like we talked about :-) |
runejo
approved these changes
Jun 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The metadata endpoint now reads an output-format parameter which lets you choose between px-json and the new json-stat2.
The json-stat2 is not complete, but cover the most common stuff.
To continue testdata for codelists, hierachy and metaid should be added, but this is perhaps better as another PR