-
Notifications
You must be signed in to change notification settings - Fork 110
Updated msconvert and Skyline to handle Agilent neutral loss/gain scan data #3634
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Updated msconvert and Skyline to handle Agilent neutral loss/gain scan data #3634
Conversation
…n scan data. Reported by user Cristina
Agilent reader test failure on TC isn't seen on my local build, trying again with the settings used on TC. |
If you didn't see that failure I have to expect you didn't actually run that test. The failure looks correct: it's a neutral loss test file (judging from NL in the filename) which we previously didn't support, so it was empty, and now we support it, so now it's not empty. :) Adding support for NL/NG isn't as simple as this though. I think we need to do something extra with the precursor or product element, I'm trying to remember/research now. |
OK, it's like this in Thermo: Did you see a way to get that offset in the Agilent API? |
Yes, the test simply didn't run locally for some reason. I'll have to dive into my standard build batch file. And yes, I missed the analyzer_scan_offset business, I'll see what I can find in the API. |
I don't see anything quite that convenient, but it should be knowable as the difference in either lower or upper bounds of Q1 and Q3 windows. |
update Skyline's Spectrum Filter mechanism to handle Constant Neutral Loss / Gain scans, so we can extract chromatograms for various precursor/CNL combinations
Reported by user Cristina