-
Notifications
You must be signed in to change notification settings - Fork 110
Enable filtering spectra on Dissociation Method #3591
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
nickshulman
merged 18 commits into
master
from
Skyline/work/20250828_DissociationMethodSpectrumFilter
Sep 15, 2025
Merged
Enable filtering spectra on Dissociation Method #3591
nickshulman
merged 18 commits into
master
from
Skyline/work/20250828_DissociationMethodSpectrumFilter
Sep 15, 2025
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…k/20250804_DissociationMethod
…thub.com/ProteoWizard/pwiz into Skyline/work/20250804_DissociationMethod
* refactored GC_DEBUG to use a Dictionary of allocations to keep track of when they're created and deleted, so a leak check can be performed on-demand; this allowed me to be sure that the leak wasn't caused by C++/CLI wrapper objects not being disposed
…k/20250804_DissociationMethod
I think this might be worth trying in master/nightly again now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Creating a new pull request for this because committing PR #3575 caused memory write errors in the nightlies.
This change allows creating spectrum filters that use "Dissociation Method".

You can also see the Dissociation Method in the Full Scan property sheet if you click on a point along an MS2 chromatogram
