Skip to content

Conversation

nickshulman
Copy link
Contributor

Creating a new pull request for this because committing PR #3575 caused memory write errors in the nightlies.

This change allows creating spectrum filters that use "Dissociation Method".
image

You can also see the Dissociation Method in the Full Scan property sheet if you click on a point along an MS2 chromatogram
image

nickshulman and others added 18 commits August 4, 2025 22:24
* refactored GC_DEBUG to use a Dictionary of allocations to keep track of when they're created and deleted, so a leak check can be performed on-demand; this allowed me to be sure that the leak wasn't caused by C++/CLI wrapper objects not being disposed
@chambm
Copy link
Member

chambm commented Sep 15, 2025

I think this might be worth trying in master/nightly again now.

@nickshulman nickshulman merged commit 08526f4 into master Sep 15, 2025
17 checks passed
@nickshulman nickshulman deleted the Skyline/work/20250828_DissociationMethodSpectrumFilter branch September 15, 2025 20:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants