-
Notifications
You must be signed in to change notification settings - Fork 261
Fix focus and navigation for ThumbnailNavigation #4196
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #4196 +/- ##
=======================================
+ Coverage 95.1% 95.1% +0.1%
=======================================
Files 326 326
Lines 16192 16199 +7
Branches 2545 2549 +4
=======================================
+ Hits 15391 15398 +7
Misses 796 796
Partials 5 5 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
@marlo-longley Yes--that definitely fixes it! 🎉 Just checked out your branch and it is behaving how I'd expect it to. Thank you so much for the quick work on this one! |
|
@marlo-longley Oh, actually -- spoke too soon (sorry). This change lets me navigate with left/right keys about four times in either direction after clicking a thumb. But after that, it won't go further and instead starts scrolling the thumb pane instead of advancing to the next page. Very strange! So this is progress, but not quite yet the expected behavior. |
|
Ahh OK I guess I didn't try more than 4 clicks?? Let me see...thanks @seanaery |
|
@seanaery give this a try? |
|
@marlo-longley Yes--excellent! That is working for me. Tested with thumbs in either position (right or bottom), and works correctly even in gallery view. Thanks! |
Closes #4195
@seanaery does this help? Locally for me this fixed it and looks like it's fixed on the Netlify preview below. I think it was interfering with the
handleKeyDownmethod in the parentThumbnailNavigation.I'll have to look at the a11y issues another time. Good catch!