Improve TorchScript model identification logic in torch_model.py #546
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Updated copyright notice to reflect the years 2021-2025. - Enhanced the logic for identifying TorchScript models by clarifying the required files and directories in the zip archive format. Signed-off-by: Gigon Bae <gbae@nvidia.com>
|
MMelQin
approved these changes
Jul 21, 2025
There was a problem hiding this comment.
Thanks @gigony for addressing this!
Edit after the merge: TorchScript itself does not save constants in a constants folder in the archive, see here, and the model file mentioned in the issue was exported with --trt_export flag, so it is the MONAI Bundle that added the constants folder instead of constants.pkl for trt optimized model.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Address #544