Skip to content

Fix: Use rotating log file w/2MB limit, changed file name 'n removed... #110

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
May 13, 2025

Conversation

SnuffSocket
Copy link
Contributor

Use rotating log file w/2MB limit.
Changed file name to "ProjectBabble.log" and removed "./Logs/ProjectBabble" folder. So logs go directly to "./Logs".

@CLAassistant
Copy link

CLAassistant commented Apr 13, 2025

CLA assistant check
All committers have signed the CLA.

@dfgHiatus dfgHiatus self-assigned this May 12, 2025
@dfgHiatus dfgHiatus added the enhancement New feature or request label May 12, 2025
@dfgHiatus dfgHiatus self-requested a review May 12, 2025 20:49
@dfgHiatus
Copy link
Contributor

Looks good! One thing we do log are user system specs, this can help us identify:

  1. What platform the app is running on
  2. What version of Python is being used to run the app (source builds vs compiled builds)
  3. Unusual hardware setups

Is it possible to include this before we start to cycle logs? Thanks, I appreciate your help with this!

@SnuffSocket
Copy link
Contributor Author

SnuffSocket commented May 13, 2025

Included system info after log rollover, as requested. :)

@dfgHiatus dfgHiatus merged commit f203df9 into Project-Babble:main May 13, 2025
2 checks passed
@SnuffSocket SnuffSocket deleted the fix-log branch June 16, 2025 11:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants