Cursor 1 21 5 #3701
Open
Cursor 1 21 5 #3701
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Review the following changes in direct dependencies. Learn more about Socket for GitHub.
|
|
All external test now passing minus sign (likely due to now using NBT): |
Closed
|
Also minor issue with unused also and will review with LLM.. This is the structure of the sign blocks now: //### Starting sign
//[06:26:07] [Server thread/INFO]: [Not Secure] <flatbot> ### Starting sign
//Sign block
Block {
type: 861,
metadata: 17,
light: 0,
skyLight: 15,
biome: {
color: 0,
height: null,
name: '',
rainfall: 0,
temperature: 0,
id: 40
},
position: Vec3 { x: 0, y: -60, z: 0 },
stateId: 20348,
computedStates: {},
name: 'warped_sign',
hardness: 1,
displayName: 'Warped Sign',
shapes: [],
boundingBox: 'empty',
transparent: true,
diggable: true,
material: 'mineable/axe',
harvestTools: undefined,
drops: [ 937 ],
_properties: { waterlogged: false, rotation: '8' },
isWaterlogged: false,
setSignText: [Function: setSignText],
getSignText: [Function: getSignText],
signText: [Getter/Setter],
entity: {
type: 'compound',
value: {
back_text: {
type: 'compound',
value: {
has_glowing_text: { type: 'byte', value: 0 },
color: { type: 'string', value: 'black' },
messages: {
type: 'list',
value: { type: 'string', value: [ '', '', '', '' ] }
}
}
},
is_waxed: { type: 'byte', value: 0 },
front_text: {
type: 'compound',
value: {
has_glowing_text: { type: 'byte', value: 0 },
color: { type: 'string', value: 'black' },
messages: {
type: 'list',
value: { type: 'string', value: [ '1', '2', '3', '' ] }
}
}
}
}
},
painting: undefined
}with no JSON encapsulation inside messages.value.value Sign (PrismarineJS/prismarine-block#115) and chunk issue should be fixed |
|
nice; looks like everything passing? |
|
Yeah, most of the broken things remaining were upstream and have been fixed |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Starting work with cursor to finish 1.21.5