Improve shared test reset: reset weather, time, effects, health, food… #3651
Conversation
…, gamerules, difficulty, and OP status to reduce flakiness across all tests.
|
Built with copilot agent |
There was a problem hiding this comment.
Pull Request Overview
This PR expands the shared test setup by issuing additional in-game chat commands to reset environmental and player state, aiming to reduce test flakiness.
- Injects chat commands to clear weather, set time, and enforce daylight/weather cycles
- Clears all potion effects and attempts health/food reset
- Resets difficulty and grants OP status to the test bot
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
There was a problem hiding this comment.
Pull Request Overview
This PR aims to improve the shared test reset process by adding commands to reset weather, time, effects, health, food, gamerules, difficulty, and OP status for increased test reliability.
- New chat commands are added for weather, time, health, food, gamerules, and OP status resets.
- The reset sequence now includes commands to clear effects and adjust player attributes to reduce test flakiness.
Comments suppressed due to low confidence (1)
test/externalTests/plugins/testCommon.js:107
- Issuing many chat commands in succession may risk command processing delays. Consider verifying individual command completions or adding incremental delays to ensure reliable execution in the test environment.
await sleep(1000)
|
looked good but then following the suggestions of the gh agent reviewed it broke everything. |
|
The interaction loop between the agent and the environment is not great yet. It should be able to quick run some internal simulation making a bet on what the consequence of its change will have on the CI |
…, gamerules, difficulty, and OP status to reduce flakiness across all tests.