-
-
Notifications
You must be signed in to change notification settings - Fork 5
[WIP] Dome structures #76
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Currently structures are not used, other domes will be added soon:tm: i am currently revamping them.
yep
|
apparently I can't assign myself for reviewing |
|
oh im doing this wrong sorry ampflower |
|
Opaque NBT blobs aren't exactly reviewable. |
|
My idea was that you'd test in game, possibly find issues, and hold samalando hostage until he fixed it |
|
but fair enough |
|
I mean once it's registered to something, sure. The structure files alone aren't going to do anything. |
|
Yeah that's why it's a draft PR and why I said I'm 99% sure I'm doing this wrong |
|
Once I finish the datapack I'll push it so it can be tested, then I'll work on the auto upload inside the mod itself |
|
You don't (and honestly shouldn't) wait to finish something and then push it. Commit changes as you make them, it will be better for you if you accidentally lose the local clone with changes that weren't pushed, and allows us to point issues out much earlier on, saving both you and reviewers a lot of time. This, of course, isn't exclusive to this PR |
|
Ok, when I get home I'll commit what I currently have (file restructuring) |
feat: work on implementation BREAKING CHANGE: doesn't work yet
idk the tag to use, prep for actual work
note: it doesnt generate structures yet, but doesnt crash :3
note: structures still don't generate
|
hm |
Currently structures are not used, other domes will be added soon:tm: i am currently revamping them.