Skip to content

Conversation

@blryface
Copy link
Member

@blryface blryface commented Apr 1, 2025

Currently structures are not used, other domes will be added soon:tm: i am currently revamping them.

Currently structures are not used, other domes will be added soon:tm: i am currently revamping them.
@blryface blryface linked an issue Apr 1, 2025 that may be closed by this pull request
@blryface blryface added this to the Future milestone Apr 1, 2025
@blryface blryface requested a review from Ampflower April 1, 2025 19:11
@blryface
Copy link
Member Author

blryface commented Apr 1, 2025

apparently I can't assign myself for reviewing

@blryface
Copy link
Member Author

blryface commented Apr 1, 2025

oh im doing this wrong sorry ampflower

@Ampflower
Copy link
Member

Opaque NBT blobs aren't exactly reviewable.

@Ampflower Ampflower removed a link to an issue Apr 2, 2025
@blryface
Copy link
Member Author

blryface commented Apr 2, 2025

My idea was that you'd test in game, possibly find issues, and hold samalando hostage until he fixed it

@blryface
Copy link
Member Author

blryface commented Apr 2, 2025

but fair enough

@Ampflower
Copy link
Member

I mean once it's registered to something, sure. The structure files alone aren't going to do anything.

@blryface
Copy link
Member Author

blryface commented Apr 2, 2025

Yeah that's why it's a draft PR and why I said I'm 99% sure I'm doing this wrong

@Samalando
Copy link

Once I finish the datapack I'll push it so it can be tested, then I'll work on the auto upload inside the mod itself

@blryface
Copy link
Member Author

blryface commented Apr 2, 2025

You don't (and honestly shouldn't) wait to finish something and then push it. Commit changes as you make them, it will be better for you if you accidentally lose the local clone with changes that weren't pushed, and allows us to point issues out much earlier on, saving both you and reviewers a lot of time.

This, of course, isn't exclusive to this PR and may not even make too much sense with the example I gave, but could/should also be done on future contributions

@Samalando
Copy link

Samalando commented Apr 2, 2025

Ok, when I get home I'll commit what I currently have (file restructuring)

feat: work on implementation
BREAKING CHANGE: doesn't work yet
idk the tag to use, prep for actual work
note: it doesnt generate structures yet, but doesnt crash :3
note: structures still don't generate
@blryface
Copy link
Member Author

hm

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants