Skip to content

Add new comparison operators #990

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 14 commits into from
Jul 24, 2025

Conversation

Gijsreyn
Copy link
Contributor

@Gijsreyn Gijsreyn commented Jul 22, 2025

PR Summary

Just trying to learn some Rust on the side and address #988 and check some boxes in #57

PR Context

This pull request adds the following comparison operators:

  • Less
  • LessOrEquals
  • Greater
  • GreaterOrEquals

fix #988

@Gijsreyn
Copy link
Contributor Author

@SteveL-MSFT or @tgauth, I know it is considered for v3.3, but if you have time, would you mind a flexible review?

Copy link
Member

@SteveL-MSFT SteveL-MSFT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

feedback applies to < and <=

@Gijsreyn Gijsreyn force-pushed the comparison-functions branch from 7bdad4e to a8d3c74 Compare July 23, 2025 02:28
@Gijsreyn Gijsreyn requested a review from SteveL-MSFT July 23, 2025 02:45
@SteveL-MSFT SteveL-MSFT added this pull request to the merge queue Jul 24, 2025
Merged via the queue into PowerShell:main with commit 0112a57 Jul 24, 2025
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Comparison functions
2 participants