Skip to content

Add check in PS Adapter in case property is $null #769

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 1, 2025
Merged

Add check in PS Adapter in case property is $null #769

merged 1 commit into from
May 1, 2025

Conversation

SteveL-MSFT
Copy link
Member

PR Summary

Issue was caught by static analysis. Ignore the whitespace changes.

There might be a chance that $validateProperty is $null so need to check that before accessing the member

@SteveL-MSFT SteveL-MSFT marked this pull request as ready for review April 28, 2025 21:55
mgreenegit
mgreenegit approved these changes May 1, 2025
View reviewed changes
Copy link
Member

@mgreenegit mgreenegit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like a simple change. The rest appears to be autoformats.

@SteveL-MSFT SteveL-MSFT merged commit 7f90fbb into PowerShell:main May 1, 2025
4 checks passed
@SteveL-MSFT SteveL-MSFT changed the title Add check in PS Adapter in case proeprty is $null Add check in PS Adapter in case property is $null May 1, 2025
@SteveL-MSFT SteveL-MSFT deleted the psadapter-check branch May 1, 2025 19:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mgreenegit mgreenegit mgreenegit approved these changes

@michaeltlombardi michaeltlombardi Awaiting requested review from michaeltlombardi

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@SteveL-MSFT @mgreenegit