-
Notifications
You must be signed in to change notification settings - Fork 35
Add support for discovery extensions #760
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
83825d3
to
a9277d8
Compare
3dc2b4c
to
87a764c
Compare
87a764c
to
27e0ae6
Compare
Currently, the implementation requires returning the absolute path to a resource manifest - but I Right now, it expects JSON like this: {"resourceManifestPath":"/foo/bar/baz.dsc.resource.json"} But we could have it return this, and parse the last segment of the path to determine kind: {"absoluteManifestPath":"/foo/bar/baz.dsc.extension.json"} Or require it return either If we support extensions discovering extensions, we would need to recursively handle extension |
const DSC_EXTENSION_EXTENSIONS: [&str; 3] = [".dsc.extension.json", ".dsc.extension.yaml", ".dsc.extension.yml"]; | ||
|
||
#[derive(Clone)] | ||
pub enum ManifestResource { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Recommend naming this either Manifest
or DscManifest
to avoid adding another instance of Resource
to our lexicon.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I was having a hard time coming up with a name that was more general, but just Manifest
is not correct, but DscManifest
given the suffix indicates it's a manifest, but it actually represents the actual resource or extension.
I think we can defer extension discovery til when we need it |
PR Summary
dsc
to list extensions:dsc extension list
discover
capability currently supported.The output from a discovery extension must match:
PR Context
Fix #681