Add support for [SecureString] in PowerShell adapter
#1208
Merged
+17
−3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3 tasks
Gijsreyn
force-pushed
the
gh-1207/main/fix-support-securestring
branch
from
a13082c to
5e08a3e
Compare
SteveL-MSFT
requested changes
Oct 24, 2025
There was a problem hiding this comment.
Pull Request Overview
This pull request adds support for [SecureString] type properties in PowerShell class-based DSC resources and fixes handling of fully qualified PSCredential property types.
- Adds conversion logic to handle
[SecureString]properties by converting plain text values to secure strings - Updates
PSCredentialtype checking to use wildcard matching for fully qualified type names - Adds test coverage for
SecureStringproperty handling
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| adapters/powershell/psDscAdapter/psDscAdapter.psm1 | Implements SecureString conversion logic and updates PSCredential type matching to handle fully qualified names |
| adapters/powershell/Tests/powershellgroup.resource.tests.ps1 | Adds test case to verify SecureString property processing |
| adapters/powershell/Tests/TestClassResource/0.0.1/TestClassResource.psm1 | Adds SecureStringProp property to test resource for validation |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Gijsreyn
force-pushed
the
gh-1207/main/fix-support-securestring
branch
from
5e08a3e to
cc35c35
Compare
SteveL-MSFT
approved these changes
Oct 27, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Summary
This pull request adds support for
[SecureString]in class-based DSC resources. Small remediation fix if a user uses the fully qualified property name on[PSCredential].PR Context
Fix #1207.