fix: autofocus on text input when open ended question is rendered #2024
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
Size Change: -438 B (-0.01%) Total Size: 3.55 MB
ℹ️ View Unchanged
|
lucasheriques
force-pushed
the
fix/survey-openquestion-autofocus
branch
from
b898f0e to
bea4bc8
Compare
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
There was a problem hiding this comment.
PR Summary
Improves survey UX by implementing consistent autofocus behavior for open text questions. This change relocates autofocus logic from the popup visibility hook to individual question components.
- Moves autofocus from
usePopupVisibilityhook toOpenTextQuestioncomponent, enabling focus on any open text question, not just the first one - Implements autofocus using
useRefanduseEffectwith a 100ms delay to ensure reliable focus - Removes duplicative focus management code, simplifying the component architecture
- Fixes minor CSS class name formatting by removing leading space in multiple choice questions
2 files reviewed, 1 comment
Edit PR Review Bot Settings | Greptile
Comment on lines
+92
to
+96
| useEffect(() => { | ||
| setTimeout(() => { | ||
| inputRef.current?.focus() | ||
| }, 100) | ||
| }, []) |
There was a problem hiding this comment.
style: Consider adding cleanup to clear timeout if component unmounts before timeout fires
Suggested change
| useEffect(() => { | |
| setTimeout(() => { | |
| inputRef.current?.focus() | |
| }, 100) | |
| }, []) | |
| useEffect(() => { | |
| const timer = setTimeout(() => { | |
| inputRef.current?.focus() | |
| }, 100) | |
| return () => clearTimeout(timer) | |
| }, []) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Moves the autofocus on for open text directly into the question component. It simplifies the logic, plus now it autofocus for any question, not just the first one (i.e. last question is an open ended)