fix: style problems in multiple/single-choice questions #2016
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
lucasheriques
added
bump patch
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
There was a problem hiding this comment.
PR Summary
This PR improves survey UI and component architecture in posthog-js by addressing multiple layout and functionality issues:
- Fixed unwanted line breaks in multiple/single choice survey options by adding
flex-shrink: 0and movingflex-wrapto open choice options only - Improved open text question autofocus by moving logic from
usePopupVisibilityhook directly intoOpenTextQuestioncomponent, making it work reliably for non-first questions - Refactored CSS organization in
survey.cssandsurveys-extension-utils.tsxby grouping non-customizable variables together and removing duplicate transition definitions - Fixed survey bottom border logic in
surveys-extension-utils.tsxby making the condition more explicit with better variable naming
4 files reviewed, no comments
Edit PR Review Bot Settings | Greptile
|
Size Change: +3.51 kB (+0.1%) Total Size: 3.56 MB
ℹ️ View Unchanged
|
lucasheriques
changed the title
lucasheriques
commented
Jun 16, 2025
src/extensions/surveys/survey.css
Outdated
Comment on lines
290
to
292
| & span { | ||
| color: inherit; | ||
| } |
There was a problem hiding this comment.
this fixes second first problem (white text color on the white background)
lucasheriques
commented
Jun 16, 2025
src/extensions/surveys/survey.css
Outdated
Comment on lines
294
to
296
| &.choice-option-open { | ||
| flex-wrap: wrap; | ||
| } |
There was a problem hiding this comment.
and this fixes the line-break problem, by only wrapping if it's an open-ended input
lucasheriques
commented
Jun 16, 2025
Comment on lines
92
to
96
| useEffect(() => { | ||
| setTimeout(() => { | ||
| inputRef.current?.focus() | ||
| }, 100) | ||
| }, []) |
There was a problem hiding this comment.
logic to autofocus on the open question input moved to here, where it makes more sense.
marandaneto
approved these changes
Jun 16, 2025
ioannisj
approved these changes
Jun 16, 2025
lucasheriques
changed the title
lucasheriques
force-pushed
the
fix/survey-line-break-for-multiple-choice
branch
from
c9ec269 to
3b03134
Compare
lucasheriques
force-pushed
the
fix/survey-line-break-for-multiple-choice
branch
from
d826c2d to
240fa0e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
This PR fixes two main problems.
First one, it prevents this line break from happening:
Second, it makes sure the label of the checkboxes/radio inputs has the proper, contrasted color:
Other misc changes
Checklist