Skip to content

Re-upgrade Claude to Sonnet 4.0 and instructed AI only to explain policies #2540

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 9 commits into
base: master
Choose a base branch
from

Conversation

SongmingFan123
Copy link
Collaborator

@SongmingFan123 SongmingFan123 commented Jun 5, 2025

Fixes #2522
Fixes #2512

Copy link

codecov bot commented Jun 5, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 71.15%. Comparing base (a216bc6) to head (4505d80).
Report is 10 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2540      +/-   ##
==========================================
+ Coverage   63.98%   71.15%   +7.16%     
==========================================
  Files          55       54       -1     
  Lines        2113     1768     -345     
  Branches      264      217      -47     
==========================================
- Hits         1352     1258      -94     
+ Misses        708      459     -249     
+ Partials       53       51       -2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@anth-volk
Copy link
Collaborator

Please use "Fixes," not "Resolves," otherwise the script doesn't work

@SongmingFan123
Copy link
Collaborator Author

Please use "Fixes," not "Resolves," otherwise the script doesn't work

Fixed, thank you for the feedback.

@MaxGhenis
Copy link
Collaborator

Please test the prompt with Claude chat a few times and drop the results in a Google doc

@SongmingFan123
Copy link
Collaborator Author

This is the link to the file containing the tests:
https://docs.google.com/document/d/1zHrKCWRpzUg8_DzHN7XdJtWbk7Micp2cD20M0RLrZKc/edit?usp=sharing

Thank you.

@MaxGhenis
Copy link
Collaborator

Please show the full text result

@anth-volk
Copy link
Collaborator

Please use specifically "Fixes #ISSUE", the format you have won't correctly close the original issue. Check out the docs for more info.

If you set it up right, this panel on the right should indicate the issue being closed:
Screen Shot 2025-06-09 at 6 02 54 PM

@SongmingFan123
Copy link
Collaborator Author

Please use specifically "Fixes #ISSUE", the format you have won't correctly close the original issue. Check out the docs for more info.

If you set it up right, this panel on the right should indicate the issue being closed: Screen Shot 2025-06-09 at 6 02 54 PM

Updated, thanks

@SongmingFan123
Copy link
Collaborator Author

Please show the full text result

Updated, thanks.

@anth-volk
Copy link
Collaborator

Also, please modify the changelog as we discussed post-meeting today to just include modifications to changelog_entry.yaml.

Copy link
Collaborator

@MaxGhenis MaxGhenis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

marking as requesting changes to receive sample results

@SongmingFan123
Copy link
Collaborator Author

marking as requesting changes to receive sample results

Could you specify what do you mean? Do you mean the references in the brackets?
Screenshot 2025-06-11 202619

@SongmingFan123
Copy link
Collaborator Author

Also, please modify the changelog as we discussed post-meeting today to just include modifications to changelog_entry.yaml.

Updated, thank you.

@MaxGhenis
Copy link
Collaborator

We avoided the upgrade because Claude 4 was adding things like FDR quotes. Please create a document of some sample LLM summaries to ensure our prompting avoids these issues.

@SongmingFan123
Copy link
Collaborator Author

We avoided the upgrade because Claude 4 was adding things like FDR quotes. Please create a document of some sample LLM summaries to ensure our prompting avoids these issues.

Updated, this is the link to the doc: https://docs.google.com/document/d/1ECOwIq2mX0CjWyxAYDevdX6vvIFKsbyibaItvPdKT_c/edit?usp=sharing
Thank you.

@anth-volk
Copy link
Collaborator

anth-volk commented Jun 16, 2025

@SongmingFan123 if you could just remove the changes you made to CHANGELOG.md and changelog.yaml, we can merge.

@SongmingFan123
Copy link
Collaborator Author

@SongmingFan123 if you could just remove the changes you made to CHANGELOG.md and changelog.yaml, we can merge.

Fixed, thank you.

@SongmingFan123
Copy link
Collaborator Author

@SongmingFan123 if you could just remove the changes you made to CHANGELOG.md and changelog.yaml, we can merge.

Changes to the files have been made. Thank you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Re-upgrade Claude to Sonnet 4.0 Instruct AI only to explain the policies, no commentary or quotes
4 participants