Skip to content

[search] Add override to KdTreeNanoflann functions #6265

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from
Draft
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions search/include/pcl/search/kdtree.h
Original file line number Diff line number Diff line change
Expand Up @@ -95,11 +95,11 @@ namespace pcl
/** \brief Provide a pointer to the point representation to use to convert points into k-D vectors.
* \param[in] point_representation the const boost shared pointer to a PointRepresentation
*/
void
virtual void
setPointRepresentation (const PointRepresentationConstPtr &point_representation);

/** \brief Get a pointer to the point representation used when converting points into k-D vectors. */
inline PointRepresentationConstPtr
virtual inline PointRepresentationConstPtr
getPointRepresentation () const
{
return (tree_->getPointRepresentation ());
Expand All @@ -114,11 +114,11 @@ namespace pcl
/** \brief Set the search epsilon precision (error bound) for nearest neighbors searches.
* \param[in] eps precision (error bound) for nearest neighbors searches
*/
void
virtual void
setEpsilon (float eps);

/** \brief Get the search epsilon precision (error bound) for nearest neighbors searches. */
inline float
virtual inline float
getEpsilon () const
{
return (tree_->getEpsilon ());
Expand Down
8 changes: 4 additions & 4 deletions search/include/pcl/search/kdtree_nanoflann.h
Original file line number Diff line number Diff line change
Expand Up @@ -333,7 +333,7 @@ class KdTreeNanoflann : public pcl::search::KdTree<PointT> {
* @param[in] point_representation the const shared pointer to a PointRepresentation
*/
void
setPointRepresentation(const PointRepresentationConstPtr& point_representation)
setPointRepresentation(const PointRepresentationConstPtr& point_representation) override
{
PCL_DEBUG("[KdTreeNanoflann::setPointRepresentation] "
"KdTreeNanoflann::setPointRepresentation called, "
Expand All @@ -356,7 +356,7 @@ class KdTreeNanoflann : public pcl::search::KdTree<PointT> {
/** @brief Get a pointer to the point representation used when converting points into
* k-D vectors. */
inline PointRepresentationConstPtr
getPointRepresentation() const
getPointRepresentation() const override
{
return point_representation_;
}
Expand All @@ -375,15 +375,15 @@ class KdTreeNanoflann : public pcl::search::KdTree<PointT> {
* @param[in] eps precision (error bound) for nearest neighbors searches
*/
void
setEpsilon(float eps)
setEpsilon(float eps) override
{
eps_ = eps;
}

/** @brief Get the search epsilon precision (error bound) for nearest neighbors
* searches. */
inline float
getEpsilon() const
getEpsilon() const override
{
return eps_;
}
Expand Down