[segmentation] Deprecate unused max_label in extractLabeledEuclideanClusters
#4105
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kunaltyagi
added
needs: code review
kunaltyagi
force-pushed
the
deprecate-unused-param
branch
from
9298e94 to
0ce2234
Compare
kunaltyagi
requested review from
larshg and
mvieth
and removed request for
taketwo and
SergioRAgostinho
larshg
approved these changes
Nov 4, 2020
|
Just resolve conflicts and its 🚀 |
kunaltyagi
force-pushed
the
deprecate-unused-param
branch
from
0ce2234 to
151be85
Compare
kunaltyagi
force-pushed
the
deprecate-unused-param
branch
from
151be85 to
d8b91d3
Compare
mvieth
reviewed
Nov 5, 2020
kunaltyagi
force-pushed
the
deprecate-unused-param
branch
from
d8b91d3 to
871250d
Compare
mvieth
reviewed
Nov 12, 2020
segmentation/include/pcl/segmentation/extract_labeled_clusters.h
Outdated
Show resolved
Hide resolved
segmentation/include/pcl/segmentation/extract_labeled_clusters.h
Outdated
Show resolved
Hide resolved
Comment on lines
+60
to
+62
| unsigned int min_pts_per_cluster, | ||
| unsigned int max_pts_per_cluster, | ||
| unsigned int max_label); |
There was a problem hiding this comment.
Missing defaults for parameters?
There was a problem hiding this comment.
This is the deprecated version. If someone is using with a parameter, only then it affects them. Adding a default to the deprecated version will create a conflict between the two versions
segmentation/include/pcl/segmentation/impl/extract_labeled_clusters.hpp
Outdated
Show resolved
Hide resolved
mvieth
approved these changes
Nov 26, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Originated in discussion at #4084
Clang-format commit is separate to ease code review, can be removed completely