Add sponge ops #86
Add sponge ops #86
Conversation
Nashtare
left a comment
Nashtare
left a comment
There was a problem hiding this comment.
added my two cents, but not too deep yet given this is still WIP
|
Opening it for review. This design restricts generics to the |
Nashtare
left a comment
Nashtare
left a comment
There was a problem hiding this comment.
@hratoanina can you fix conflicts and resolve all addressed comments so we can do another round of review? thanks
|
I merged with the current design, which is very different from Alonso's approach with a dedicated config per non primitive op. If Alonso's approach is favoured it should be merged before this PR, and I'll merge on top of it. |
| self.inputs.clear(); | ||
| self.reset_flag = true; | ||
| } | ||
|
|
There was a problem hiding this comment.
Add some comments explaining what these functions are doing?
circuit/src/tables.rs
Outdated
| pub fn run(mut self) -> Result<Traces<F>, CircuitError> { | ||
| pub fn run< | ||
| P: CryptographicPermutation<[F; N]>, | ||
| const N: usize, |
circuit/src/tables.rs
Outdated
| let mut current_hash = | ||
| if let Some(val) = self.witness.get(leaf.0 as usize).and_then(|x| x.as_ref()) { | ||
| *val | ||
| // Only handle FakeMerkleVerify ops here |
|
|
||
| fn main() -> Result<(), ProverError> { | ||
| let mut rng = SmallRng::seed_from_u64(1); | ||
| let perm = Poseidon2BabyBear::<HASH_STATE_SIZE>::new_from_rng_128(&mut rng); |
There was a problem hiding this comment.
I think you could also do default_babybear_poseidon2_16()
| rate_values.push(val); | ||
| } | ||
|
|
||
| // for i in 0..R { |
|
On hold, we might go with a circuit approach for the challenger instead, using hashing tables directly (see #131). |
|
@hratoanina should we just close this? |
github-project-automation
bot
moved this from Ready for review
to Done
in Plonky3 Recursion
Opening as draft for visibility and for the API. I'm having trouble making it generic for the hash function. It technically compiles and runs, but I'm not satisfied with some of the design.