Add verify_circuit
#74
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Add Div primary operation
Contributor
Author
|
I created a PR from a new branch for a cleaner history |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR aims at adding
verify_circuit, which is the recursive equivalent ofverify.It is based on the branch
linda/traitsince this requires a couple of trait methods. But since I also neededdiv, I rebased on latest main, which means the two branches have diverged. The only actual changes are in this commit, and so it should be enough to check the filecircuit_verifier.rs.I am opening a draft PR so you can look at how the methods in the traits can be used, and so you can let me know whether we wanted a different approach for the verifying circuit!
closes #31